Gpt2 notebook example #3217
Gpt2 notebook example #3217
Conversation
…st example using vegeta tool
…ldon-core into gpt2_notebook_example
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -9,17 +9,20 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
| @@ -9,17 +9,20 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Should we remove the try / except block? I.e. just leave the res = ret.json() to simplify the snippet?
Reply via ReviewNB
There was a problem hiding this comment.
I added this block as when running in loop (while) may cause some request to return with empty ret => ret.json() throw exception. I believe it is a timing issue/ load on the model as without calling request in loop never happens to me. I added the try block to make sure the script returns a sentences completion.
I find it O.K to leave it that way - I don't think it impairs the readability / understanding. Let me know if you prefer it to be removed
| @@ -9,17 +9,20 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It makes sense - ran it
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failed to merge this PR due to:
|
What this PR does / why we need it:
Extend notebook to contain an example of a simple load test using Vegeta
Which issue(s) this PR fixes:
Fixes #3216
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE