Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istio host annotation #3244

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Add istio host annotation #3244

merged 3 commits into from
Jun 4, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Allows the istio host to be specified for VirtualService creation

Which issue(s) this PR fixes:

Fixes #3137

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo May 28, 2021 15:02
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor

Looks good! Should be good go - the notebook tests have been fixed in master as well so after rebasing should be able to rerun.

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

2 similar comments
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

Seems flaky tests failure
/test integration

@axsaucedo
Copy link
Contributor

It seems flaky test now passes, so looks good - merging

@axsaucedo axsaucedo merged commit a5c5146 into SeldonIO:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for overriding Istio VirtualService hosts
3 participants