-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add istio host annotation #3244
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test notebooks |
/test integration |
/test notebooks |
/test integration |
/test notebooks |
Looks good! Should be good go - the notebook tests have been fixed in master as well so after rebasing should be able to rerun. |
/test integration |
/test notebooks |
/test integration |
/test notebooks |
/test integration |
2 similar comments
/test integration |
/test integration |
Seems flaky tests failure |
It seems flaky test now passes, so looks good - merging |
What this PR does / why we need it:
Allows the istio host to be specified for VirtualService creation
Which issue(s) this PR fixes:
Fixes #3137
Special notes for your reviewer:
Does this PR introduce a user-facing change?: