Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new jx job #3432

Merged
merged 8 commits into from
Jul 30, 2021
Merged

add new jx job #3432

merged 8 commits into from
Jul 30, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 27, 2021

What this PR does / why we need it:

Follow up of #3425 to automate build/push of models as part of CI job.

Which issue(s) this PR fixes:

Fixes #3439

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor Author

/test models

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor Author

/test models

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

4 similar comments
@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

2 similar comments
@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test models

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/test models

@axsaucedo axsaucedo changed the title add new jx job WIP: add new jx job Jul 27, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski RafalSkolasinski marked this pull request as draft July 28, 2021 16:21
@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor Author

/test release

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
release-build-push 9af256a link /test release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

/test models

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review July 28, 2021 23:09
@RafalSkolasinski RafalSkolasinski changed the title WIP: add new jx job add new jx job Jul 28, 2021
@RafalSkolasinski
Copy link
Contributor Author

All good and working. Happy to discuss Makefile's targets name but this will do the job for now!

@axsaucedo axsaucedo merged commit 71efc23 into SeldonIO:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatise generation and upload of example models for pre-packaged model servers
3 participants