Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parallel documentation build #3437

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

It looks like the sphinx_search.extension plugin that was added recently to the docs (#3433) doesn't support building the docs in parallel.
The build itself works, but it will trigger a warning that makes our CI/CI pipeline fail.

To account for the above, this PR disables the parallel build (by removing the -j auto flag) on the make html docs target, which is the one used in our CI/CD pipeline.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz adriangonz requested a review from axsaucedo July 28, 2021 13:34
@ukclivecox ukclivecox merged commit dfe84d8 into SeldonIO:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants