Adding elastic loggging for drift detector data #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcheah
approved these changes
Sep 2, 2021
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
axsaucedo
suggested changes
Sep 2, 2021
|
NIce |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo, michaelcheah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stephen37
pushed a commit
to stephen37/seldon-core
that referenced
this pull request
Dec 21, 2021
* Adding elastic loggging for drift detector data * Updating req-logger index name * Minor fixes from review * Fixing unrelated lint issues * Fixing unrelated lint issues * Fixing PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds elasticsearch logging for alibi specific drift detector metrics in the request logger component
Special notes for your reviewer:
There are no breaking changes introduced but does involve creating a new index pattern, so the elastic token needs the required permissions
Does this PR introduce a user-facing change?:
Adds new log entry with drift detector data