Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-3372 #3654

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Issue-3372 #3654

merged 1 commit into from
Oct 11, 2021

Conversation

westford14
Copy link
Contributor

What this PR does / why we need it:

This PR address #3372 and also cleans up some of the some of the requirements.txt files as well. The en_core_web_sm installation was not working and has to be explicitly linked to the location of the tar.gz file in Spacy's repo.

Which issue(s) this PR fixes:

Fixes #3372

Special notes for your reviewer:

This is my first time contributing, so let me know if this looks okay.

Does this PR introduce a user-facing change?: Yes

* Added clearer instructions in the Kubeflow README.md file 
* Fixed broken installations in pipeline steps 

…of s2i in the README, updating the rquirements files to include pandas in the data_download pipeline step, update the requirements to point to the tar of the en_core_web_sm package since it cannot be pip installed, and small formatting changes to pipeline steps
@seldondev
Copy link
Collaborator

Hi @westford14. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@westford14
Copy link
Contributor Author

/assign @SachinVarghese

@axsaucedo
Copy link
Contributor

Looks good, thanks for the contribution @westford14
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 7daf312 into SeldonIO:master Oct 11, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
…of s2i in the README, updating the rquirements files to include pandas in the data_download pipeline step, update the requirements to point to the tar of the en_core_web_sm package since it cannot be pip installed, and small formatting changes to pipeline steps (SeldonIO#3654)

Co-authored-by: Alex Lee <alexander.lee@nytimes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lacking requirements in Kubeflow example
5 participants