Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ginkgo Make target #3709

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

agrski
Copy link
Contributor

@agrski agrski commented Oct 28, 2021

What this PR does / why we need it:
Running tests in the operator module requires ginkgo.
There is no target in the Makefile to install ginkgo and no documentation on this either.
This PR adds the target and uses it when running tests under <ROOT>/operator.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@agrski
Copy link
Contributor Author

agrski commented Oct 28, 2021

From looking at the workflow for operator/test, I can see it's run in core-builder, the Dockerfile for which has a lot of dependencies.
Running make test locally still fails for me due to missing these dependencies, e.g. kubebuilder.

As such, I suspect adding a ginkgo target isn't actually useful.
Perhaps it's be more useful to have a target that essentially does what the workflow does - run make test in the right container?

@axsaucedo
Copy link
Contributor

Nice one
/approve

@axsaucedo axsaucedo merged commit 799b4a4 into SeldonIO:master Nov 2, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agrski agrski deleted the add-ginkgo-make-target branch November 3, 2021 12:21
@agrski
Copy link
Contributor Author

agrski commented Nov 3, 2021

For anyone reading this later: installing ginkgo gets one step on, but be aware that you'll still need kubebuilder and possibly other tools.

The best way to use the make targets locally is to use the seldonio/core-builder image and run make -C operator test in that, as in the operator test workflow.

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
* Add Make target for Ginkgo installation

* Use Ginkgo target for testing

* Fix typos in Make command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants