Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade alibi to 0.6.2 #3765

Merged
merged 10 commits into from
Nov 25, 2021
Merged

upgrade alibi to 0.6.2 #3765

merged 10 commits into from
Nov 25, 2021

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Nov 24, 2021

What this PR does / why we need it:

Upgrade v1 explainer server to use alibi 0.6.2 release

we also move mlserver version to match this upgrade (for v2 protocol)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -27,7 +27,8 @@ def make_anchor_image(dirname: Optional[Path] = None) -> AnchorImage:

# we drop the first batch dimension because AnchorImage expects a single image
image_shape = model.get_layer(index=0).input_shape[0][1:]
alibi_model = AnchorImage(predictor=model, image_shape=image_shape)

alibi_model = AnchorImage(predictor=model.predict, image_shape=image_shape)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because call returns a tensor and alibi 0.6.2 will complain that it doesnt return numpy. predict does return numpy.

@seldondev seldondev added size/L and removed size/M labels Nov 24, 2021
protobuf = "^3.17.3"
alibi = {extras = ["shap"], version = "^0.6.2"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep source of dependency as Github (but bump to 0.40.x indeed) as discussed offline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sakoush
Copy link
Member Author

sakoush commented Nov 25, 2021

/test integration

@sakoush
Copy link
Member Author

sakoush commented Nov 25, 2021

/test integration

@sakoush
Copy link
Member Author

sakoush commented Nov 25, 2021

/test integration

@sakoush
Copy link
Member Author

sakoush commented Nov 25, 2021

/test integration

@seldondev
Copy link
Collaborator

@sakoush: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 1406e90 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@sakoush sakoush merged commit 9a7ca87 into SeldonIO:master Nov 25, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
* upgrade alibi to 0.6.2

* add a test for tf/triton v2 explain

* add more tests + specify shap as explicit GH dependency

* add tf protocol explain test

* run all tests even if they fail

* remove link to explainer_examples.ipynb in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants