-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade alibi to 0.6.2 #3765
upgrade alibi to 0.6.2 #3765
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -27,7 +27,8 @@ def make_anchor_image(dirname: Optional[Path] = None) -> AnchorImage: | |||
|
|||
# we drop the first batch dimension because AnchorImage expects a single image | |||
image_shape = model.get_layer(index=0).input_shape[0][1:] | |||
alibi_model = AnchorImage(predictor=model, image_shape=image_shape) | |||
|
|||
alibi_model = AnchorImage(predictor=model.predict, image_shape=image_shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protobuf = "^3.17.3" | ||
alibi = {extras = ["shap"], version = "^0.6.2"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep source of dependency as Github (but bump to 0.40.x indeed) as discussed offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/test integration |
/test integration |
/test integration |
/test integration |
@sakoush: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
* upgrade alibi to 0.6.2 * add a test for tf/triton v2 explain * add more tests + specify shap as explicit GH dependency * add tf protocol explain test * run all tests even if they fail * remove link to explainer_examples.ipynb in docs
What this PR does / why we need it:
Upgrade v1 explainer server to use alibi
0.6.2
releasewe also move mlserver version to match this upgrade (for v2 protocol)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: