Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference to kfserving storage initializer from dockerhub #3832

Merged
merged 1 commit into from
Jan 7, 2022
Merged

reference to kfserving storage initializer from dockerhub #3832

merged 1 commit into from
Jan 7, 2022

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

kfserving/storage-initializer images were temporarily not available for download due to gcr project issues kserve/kserve#1976

this move reference to source of images from dockerhub as suggested in the reference issue

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some other references:

  • operator/controllers/suite_test.go
    127:	"image" : "gcr.io/kfserving/storage-initializer:v0.4.0",
    
  • operator/controllers/model_initializer_injector_test.go
    37:	g.Expect(d.Spec.Template.Spec.InitContainers[0].Image).To(Equal("gcr.io/kfserving/storage-initializer:v0.4.0"))
    
  • operator/utils/k8s/testdata/configmap.yaml
    5:  storageInitializer: '{"cpuLimit":"1","cpuRequest":"100m","image":"gcr.io/kfserving/storage-initializer:v0.4.0","memoryLimit":"1Gi","memoryRequest":"100Mi"}'
    
  • operator/config/manager/configmap.yaml
    87:        "image" : "gcr.io/kfserving/storage-initializer:v0.4.0",
    

@seldondev seldondev added size/M and removed size/S labels Jan 7, 2022
@RafalSkolasinski
Copy link
Contributor Author

Thanks @agrski, for some reason my search+replace didn't catch all of these

Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: agrski
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski merged commit 64825de into SeldonIO:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants