Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump seldon-deploy-sdk to 1.4.1.2 in request logger #3838

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

Bump the version of the SDK in the request logger to 1.4.1.2, including a patch for auth.

Which issue(s) this PR fixes:

Part of #3825

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

5 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RafalSkolasinski,axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

3 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3838]: [Method Not Allowed]

@seldondev seldondev merged commit 243d789 into SeldonIO:master Jan 11, 2022
@axsaucedo
Copy link
Contributor

Issue caused due to jx reconfigured to do merge commits and only squash commits allowed in repo - allowed merge commits to fix for now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants