Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events to namespaced roles #3855

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Add events to namespaced roles #3855

merged 1 commit into from
Jan 17, 2022

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Fixes namespaced RBAC for manager

Which issue(s) this PR fixes:

Fixes #2179

Special notes for your reviewer:

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

@cliveseldon: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks fd90d0d link /test notebooks
integration fd90d0d link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox ukclivecox requested a review from axsaucedo January 17, 2022 07:57
@axsaucedo
Copy link
Contributor

Looks good - all integration tests pass, only failed ones are being covered via #3856 & #3857
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 57e8f08 into SeldonIO:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing RBAC resource for single namespace deployment
3 participants