Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nbqa linting for latest notebook #3991

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Mar 17, 2022

What this PR does / why we need it:

Fixes broken tests:

  • Python lint with noqa
  • Docs lint with broken link
  • Docs build with unreferenced link

Running nbqa to fix the lint of relevant notebooks.

nbqa black \
        ../ --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev added size/S and removed size/XS labels Mar 17, 2022
@axsaucedo
Copy link
Contributor Author

All tests fixed, merging

@axsaucedo axsaucedo merged commit 990a903 into SeldonIO:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants