Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example yaml file error in README.md #3994

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix example yaml file error in README.md #3994

merged 2 commits into from
Mar 18, 2022

Conversation

akfmdl
Copy link
Contributor

@akfmdl akfmdl commented Mar 18, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes: The original example yaml file causes errors because of wrong Indentation and hyphen

Fixes #

Special notes for your reviewer:

@seldondev
Copy link
Collaborator

Hi @akfmdl. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@akfmdl
Copy link
Contributor Author

akfmdl commented Mar 18, 2022

/assign @agrski

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

Nice one thanks @akfmdl

@axsaucedo axsaucedo merged commit 4d0d98f into SeldonIO:master Mar 18, 2022
@akfmdl akfmdl deleted the fix/readme branch March 19, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants