Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade alibi explain to 0.7.0 #4112

Merged
merged 2 commits into from
May 24, 2022
Merged

upgrade alibi explain to 0.7.0 #4112

merged 2 commits into from
May 24, 2022

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Closes #4098

Special notes for your reviewer:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@seldondev seldondev added size/L and removed size/S labels May 23, 2022
@RafalSkolasinski RafalSkolasinski requested a review from sakoush May 23, 2022 14:07
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@axsaucedo axsaucedo requested review from axsaucedo and jklaise May 23, 2022 14:57
jklaise
jklaise reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sakoush
sakoush approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, sakoush

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 06653a6 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

Integration failure on test_graph_v2[False]

@axsaucedo
Copy link
Contributor

Validated _v2 test failed passes locally

@axsaucedo axsaucedo merged commit 3de58f2 into SeldonIO:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklaise jklaise jklaise left review comments

@sakoush sakoush sakoush approved these changes

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Alibi Explain Server to use Alibi 0.7.0
5 participants
@RafalSkolasinski @axsaucedo @seldondev @sakoush @jklaise