Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to set operator-wide default for request logging #726

Merged
merged 2 commits into from
Jul 25, 2019
Merged

option to set operator-wide default for request logging #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79a1546
option to set operator-wide default for request logging
ryandawsonuk Jul 25, 2019
7e1aecd
default to request logging on for full setup
ryandawsonuk Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/graph/annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Otherwise any annotations starting with `seldon.io/engine-` will be interpreted
* ```seldon.io/engine-log-messages-externally``` : Option to turn on logging of requests via a logging service
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_MESSAGES_EXTERNALLY
* ```seldon.io/engine-log-message-type``` : Option to override type set on messages when sending to logging service
* ```seldon.io/engine-log-message-type``` : Option to override type set on messages when sending to logging service. Used to determine which logger impl
* Locations : SeldonDeployment.spec.predictors.annotations
* Translates to the environment variable LOG_MESSAGE_TYPE
* ```seldon.io/engine-message-logging-service``` : Option to override url to broker that sends to logging service
Expand Down
2 changes: 1 addition & 1 deletion examples/centralised-logging/full-setup-existing-kubeflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ helm init --service-account tiller

kubectl rollout status -n kube-system deployment/tiller-deploy

helm install --name seldon-core ../../helm-charts/seldon-core-operator/ --namespace seldon-system --set istio.gateway="kubeflow-gateway.kubeflow.svc.cluster.local" --set istio.enabled="true"
helm install --name seldon-core ../../helm-charts/seldon-core-operator/ --namespace seldon-system --set istio.gateway="kubeflow-gateway.kubeflow.svc.cluster.local" --set istio.enabled="true" --set engine.logMessagesExternally="true"

kubectl rollout status -n seldon-system statefulset/seldon-operator-controller-manager

Expand Down
2 changes: 1 addition & 1 deletion examples/centralised-logging/full-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ helm init --service-account tiller

kubectl rollout status -n kube-system deployment/tiller-deploy

helm install --name seldon-core ../../helm-charts/seldon-core-operator/ --namespace seldon-system
helm install --name seldon-core ../../helm-charts/seldon-core-operator/ --namespace seldon-system --set engine.logMessagesExternally="true"

kubectl rollout status -n seldon-system statefulset/seldon-operator-controller-manager

Expand Down
2 changes: 2 additions & 0 deletions helm-charts/seldon-core-operator/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ spec:
- name: ENGINE_CONTAINER_USER
value: '{{ .Values.engine.user }}'
{{- end }}
- name: ENGINE_LOG_MESSAGES_EXTERNALLY
value: '{{ .Values.engine.logMessagesExternally }}'
- name: PREDICTIVE_UNIT_SERVICE_PORT
value: '{{ .Values.predictiveUnit.port }}'
- name: ENGINE_SERVER_GRPC_PORT
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/seldon-core-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ engine:
serviceAccount:
name: default
user: 8888
#whether to log messages through knative broker to logger service
logMessagesExternally: false
image:
pullPolicy: Always
registry: docker.io
Expand Down