Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

microservice: Fix get annotations format #932

Merged
merged 2 commits into from
Oct 10, 2019
Merged

microservice: Fix get annotations format #932

merged 2 commits into from
Oct 10, 2019

Conversation

hyche
Copy link
Contributor

@hyche hyche commented Oct 10, 2019

  • Only split at the first occurence of '=', this allow values containing
    '=' character.
  • Strip splitted parts, so we can have following forms:
    key = value, or key= value
  • Also fix wrong index access annotation value, [1:-1] slices the content
    from 1 to second last, which leads to incompleted values.

microservice: Fix get annotations format
6082d33 
- Only split at the first occurence of '=', this allow values containing
  '=' character.
- Strip splitted parts, so we can have following forms:
  `key = value`, or `key= value `
- Also fix wrong index access annotation value, [1:-1] slices the content
  from 1 to second last, which leads to incompleted values.
@seldondev
Copy link
Collaborator

Hi @hyche. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hyche
Copy link
Contributor Author

hyche commented Oct 10, 2019

/assign @cliveseldon

@ukclivecox
Copy link
Contributor

Looks good. Can you add a test for this?

@hyche
Copy link
Contributor Author

hyche commented Oct 10, 2019

@cliveseldon done

@seldondev seldondev added size/M and removed size/XS labels Oct 10, 2019
@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit dc2e933 into SeldonIO:master Oct 10, 2019
@hyche hyche deleted the fix-annotations branch October 10, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

@gipster gipster Awaiting requested review from gipster

Assignees
No one assigned
Labels
approved ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyche @seldondev @ukclivecox