Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explainer and endpoint defaulting in webhook #955

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix explainer and endpoint defaulting in webhook #955

merged 1 commit into from
Oct 16, 2019

Conversation

ukclivecox
Copy link
Contributor

  • Explainer config args need to be sorted
  • Endpoint defaulting for prepackaged servers needed to stop panic in webhook

@seldondev seldondev requested review from gipster and jklaise October 16, 2019 09:43
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/retest

@ukclivecox ukclivecox merged commit c3e7e1d into SeldonIO:master Oct 16, 2019
@ukclivecox ukclivecox deleted the issue_954_explainer_args branch February 14, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants