Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Http Status Code in REST Predict #989

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

lennon310
Copy link
Contributor

Set http status code if the status field contains a non-200 code in /predict response. This avoids clients to handle the exception by creating the response by themselves in predict or predict_raw function. The code change should only affect REST code path.
Unit tests passed.

@seldondev
Copy link
Collaborator

Hi @lennon310. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@axsaucedo
Copy link
Contributor

Thank you for your contribution @lennon310 - looks fantastic! I added a few comments. There seems to be some merge conflicts as well so may be required to rebase / merge master

@axsaucedo
Copy link
Contributor

/ok-to-test

@lennon310
Copy link
Contributor Author

Thanks @axsaucedo. Looks like the conflict was resolved.

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit c10c321 into SeldonIO:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants