Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled dropdown causes layout shifts #861

Open
hvilander opened this issue Mar 1, 2023 · 1 comment · Fixed by #870
Open

Disabled dropdown causes layout shifts #861

hvilander opened this issue Mar 1, 2023 · 1 comment · Fixed by #870
Assignees
@aharpt

Comments

@hvilander
Copy link
Contributor

image

vs

Screenshot 2023-03-01 at 08 12 07

Ideally we know how big the helper text is and should add that amount of padding when the field is disabled.

I believe this would make for nicer forms when we are dynamically disabling dropdown fields.
@aharpt aharpt self-assigned this Mar 20, 2023
aharpt pushed a commit that referenced this issue Mar 20, 2023
fix: 🐛 Fix dropdown layout shift on disable
d1767b0 
✅ Closes: #861
@aharpt aharpt mentioned this issue Mar 20, 2023
Merged
@20BBrown14
Copy link
Contributor

20BBrown14 commented Mar 22, 2023 •
edited
Loading

Could you give a bit of code context for this? I'm unable to replicate this in storybook

Nvm, I'm a ding dong. I was trying this on a branch that has a fix for the issue already lol

aharpt pushed a commit that referenced this issue Mar 24, 2023
chore: 🤖 Render empty helper text/remove padding
ae0f590 
✅ Closes: #861
laurelbean pushed a commit that referenced this issue Apr 13, 2023
@aharpt
fix: 🐛 Fix dropdown layout shift on disable (#870)
60959a6 
* fix: 🐛 Fix dropdown layout shift on disable

✅ Closes: #861

* chore: 🤖 Render empty helper text/remove padding

✅ Closes: #861

---------

Co-authored-by: Aaron Harpt <aaron.harpt@selectquote.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharpt aharpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Fix dropdown layout shift on disable SelectQuoteLabs/SQForm
3 participants
@hvilander @aharpt @20BBrown14