Use PhantomData over a string for query error #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
PhantomData
over a&'static str
thiserror::Error
macro to not manually implementError
andDisplay
, bonus is it makes implementation more concise.struct
+enum
instead of anenum
with many branches that all have the same fields forQueryEntityError
.Note that it doesn't make sense to verify that the type is correct in the error message since it's guarenteed at compile time now.
What is left to do
QuerySingleError
Vec<ComponentMismatch>
fromErrorType
, it is a huge blocker.QueryEntityError<ErrInfo<Q, F>>
by aQueryEntityError<Q, F>
. You could define a type alias so thatQueryEntityError<Q::ReadOnly, F>
can be used asReadQueryEntityError<Q, F>
Note that I spent an hour preparing this :)