[🐛 Bug]: Error setting name in helm release

[maksim-paskal]

What happened?

Error while installing helm release

helm template my-release-name ./charts/selenium-grid \
--set-string chromeNode.nameOverride=my-chrome-name \
--set-string hub.nameOverride=my-hub-name \
| kubectl apply --dry-run=server -f -

Relevant log output

The Deployment "my-chrome-name" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app":"my-chrome-name", "app.kubernetes.io/component":"selenium-grid-4.15.0-20231102", "app.kubernetes.io/instance":"my-release-name", "app.kubernetes.io/managed-by":"helm", "app.kubernetes.io/name":"my-chrome-name", "app.kubernetes.io/version":"4.15.0-20231102", "helm.sh/chart":"selenium-grid-0.24.0"}: `selector` does not match template `labels`

Helm version

version.BuildInfo{Version:"v3.11.3", GitCommit:"323249351482b3bbfc9f5004f65d400aa70f9ae7", GitTreeState:"clean", GoVersion:"go1.20.3"}

[github-actions]

@maksim-paskal, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[github-actions]

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

[maksim-paskal]

@VietND96 this issue goes after your commit

How about to use name with it static name?

[VietND96]

Hi @maksim-paskal , could you please confirm that when .nameOverride is set, all resources name belong to particular component will use that name accordingly? For example when helm upgrade -i my-release-name --set-string chromeNode.nameOverride=my-chrome-name --set-string hub.nameOverride=my-hub-name .\selenium-grid-0.24.1.tgz
kubectl get pods

NAME                                     READY   STATUS    RESTARTS   AGE   LABELS
my-chrome-name-84dd7bf974-sd29p          1/1     Running   0          34s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=helm,app.kubernetes.io/name=my-chrome-name,app.kubernetes.io/version=4.15.0-20231110,app=my-chrome-name,helm.sh/chart=selenium-grid-0.24.1,pod-template-hash=84dd7bf974
my-hub-name-5dc96c99d9-rph2v             1/1     Running   0          34s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=helm,app.kubernetes.io/name=my-hub-name,app.kubernetes.io/version=4.15.0-20231110,app=my-hub-name,helm.sh/chart=selenium-grid-0.24.1,pod-template-hash=5dc96c99d9
selenium-edge-node-5b6657478c-q5q6l      1/1     Running   0          34s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=helm,app.kubernetes.io/name=selenium-edge-node,app.kubernetes.io/version=4.15.0-20231110,app=selenium-edge-node,helm.sh/chart=selenium-grid-0.24.1,pod-template-hash=5b6657478c
selenium-firefox-node-74d4c5b465-h8frs   1/1     Running   0          34s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=helm,app.kubernetes.io/name=selenium-firefox-node,app.kubernetes.io/version=4.15.0-20231110,app=selenium-firefox-node,helm.sh/chart=selenium-grid-0.24.1,pod-template-hash=74d4c5b465

kubectl get svc

NAME                    TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                      AGE     LABELS
my-chrome-name          ClusterIP   10.111.80.35     <none>        6900/TCP                     5m31s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=Helm,app.kubernetes.io/version=4.15.0-20231110,helm.sh/chart=selenium-grid-0.24.1,name=my-chrome-name
my-hub-name             ClusterIP   10.100.217.109   <none>        4444/TCP,4442/TCP,4443/TCP   5m31s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=Helm,app.kubernetes.io/version=4.15.0-20231110,app=my-hub-name,helm.sh/chart=selenium-grid-0.24.1
selenium-edge-node      ClusterIP   10.111.74.203    <none>        6900/TCP                     5m31s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=Helm,app.kubernetes.io/version=4.15.0-20231110,helm.sh/chart=selenium-grid-0.24.1,name=selenium-edge-node
selenium-firefox-node   ClusterIP   10.99.180.116    <none>        6900/TCP                     5m31s   app.kubernetes.io/component=selenium-grid-4.15.0-20231110,app.kubernetes.io/instance=my-release-name,app.kubernetes.io/managed-by=Helm,app.kubernetes.io/version=4.15.0-20231110,helm.sh/chart=selenium-grid-0.24.1,name=selenium-firefox-node

If this outcome is correct your expectation, I will raise PR to fix this soon

[maksim-paskal]

@VietND96 how can I get selenium-grid-0.24.1.tgz ? I already create changes to fix my issue, I want to know is it OK for you if I will use static name instead fullname func as you commited.

[VietND96]

@maksim-paskal , here is my change for 0.24.1 trunk...ndviet:docker-selenium:trunk
In this change, I updated the template function in labels also. The difference is when .overrideName is set, it will affect wherever the static name was used before.
Can you please comment on which is better?
You can add this repo to get chart 0.24.1 contains my change https://www.ndviet.org/docker-selenium/
or download directly https://github.com/ndviet/docker-selenium/releases/download/selenium-grid-0.24.1/selenium-grid-0.24.1.tgz

[maksim-paskal]

@VietND96 thanks, your changes also is working for me. Go ahead, it will be a fix to your previous contribution.

I don't use autoscaling, I don't tested, but pod, svc and ingress objects its fine to me.

[VietND96]

@maksim-paskal, thank you for your confirmation!

[VietND96]

Hi @maksim-paskal, the fix is released in chart version 0.25.1