Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update for Firefox node on Ubuntu Jammy #2001

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Nov 10, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Update for Firefox node on ubuntu jammy
Commit come to branch ubuntu-jammy in part of PR #1923
Update newer based image ubuntu:jammy-20231004

Motivation and Context

Firefox browser (latest - 119.0.1) failed to start with the below errors

XPCOMGlueLoad error for file /opt/firefox-latest/libmozgtk.so:
libgtk-3.so.0: cannot open shared object file: No such file or directory
Couldn't load
XPCOMGlueLoad error for file /opt/firefox-119.0.1/libxul.so:
libdbus-glib-1.so.2: cannot open shared object file: No such file or directory
Couldn't load XPCOM

Fix: in Dockerfile add apt-get install these 2 packages libgtk-3-dev, libdbus-glib-1-dev

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 mentioned this pull request Nov 10, 2023
8 tasks
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit 78802f9 into SeleniumHQ:ubuntu-jammy Nov 10, 2023
3 checks passed
diemol added a commit that referenced this pull request Nov 10, 2023
* Switching to Jammy

* Update for Firefox node on ubuntu jammy (#2001)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

---------

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

[deploy]
@VietND96 VietND96 changed the title Update for Firefox node on ubuntu jammy feat: Update for Firefox node on Ubuntu Jammy Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants