-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature run selenium tests grid on kubernetes via helm chart #2027
Feature run selenium tests grid on kubernetes via helm chart #2027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Why do we need to duplicate the tests file?
I may have overlooked DRY principle. Let me refactor the test.py to make it kubernetes aware and not spinning up docker containers. I will push the new commit when ready. |
@diemol I have made changes suggested to reuse existing test.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @amardeep2006!
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This is regarding #1975
I have enhanced the GitHub workflow to run existing selenium test cases against the selenium grid deployed in kind kubernetes cluster.
Motivation and Context
It will increase helm chart testability. It makes use of existing test cases. This is how it works :
I have intentionally deployed and tested the Chrome, Edge and Firefox pods one by one because of GitHub runner limitations. The KIND cluster was facing insufficient CPU if we deploy all pods in one go.
Types of changes
Checklist