-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ENV variable SE_VNC_PASSWORD contains sensitive data #2061
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the actual change I should review? I see many unrelated things to the VNC password.
From what I've read, the tool considers that an ENV setting containing a name with "PASSWORD" in it is a security concern. For me, it's NOT |
I have highlighted those via individual comments. |
Thank you! In general, we try to have a commit/PR to contain a single set of related changes. Would be nice to follow that idea in the future. |
Sure, thank you! Except only 1 this PR that mixed something else work-in-progress |
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
bug: ENV variable SE_VNC_PASSWORD contains sensitive data
Motivation and Context
Types of changes
Checklist