Skip to content

Commit

Permalink
[rb] do not pass options it is an instance variable
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Jan 10, 2024
1 parent 90dab59 commit 13ea716
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions rb/lib/selenium/webdriver/common/driver_finder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def paths
Platform.assert_executable(path)
{driver_path: path}
else
output = SeleniumManager.binary_paths(*to_args(@options))
output = SeleniumManager.binary_paths(*to_args)
formatted = {driver_path: Platform.cygwin_path(output['driver_path'], only_cygwin: true),
browser_path: Platform.cygwin_path(output['browser_path'], only_cygwin: true)}
Platform.assert_executable(formatted[:driver_path])
Expand All @@ -63,19 +63,19 @@ def paths
end
end

def to_args(options)
args = ['--browser', options.browser_name]
if options.browser_version
def to_args
args = ['--browser', @options.browser_name]
if @options.browser_version
args << '--browser-version'
args << options.browser_version
args << @options.browser_version
end
if options.respond_to?(:binary) && !options.binary.nil?
if @options.respond_to?(:binary) && !@options.binary.nil?
args << '--browser-path'
args << options.binary.gsub('\\', '\\\\\\')
args << @options.binary.gsub('\\', '\\\\\\')
end
if options.proxy
if @options.proxy
args << '--proxy'
args << (options.proxy.ssl || options.proxy.http)
args << (@options.proxy.ssl || @options.proxy.http)
end
args
end
Expand Down

0 comments on commit 13ea716

Please sign in to comment.