Skip to content

Commit

Permalink
[java] remove netty http client and use native java client by default
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Sep 30, 2023
1 parent 05281bd commit 7c14bff
Show file tree
Hide file tree
Showing 11 changed files with 9 additions and 805 deletions.
2 changes: 1 addition & 1 deletion java/src/org/openqa/selenium/remote/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ java_library(
"//java/src/org/openqa/selenium/json",
"//java/src/org/openqa/selenium/manager",
"//java/src/org/openqa/selenium/os",
"//java/src/org/openqa/selenium/remote/http/netty",
"//java/src/org/openqa/selenium/remote/http/jdk",
"//java/src/org/openqa/selenium/remote/tracing",
"//java/src/org/openqa/selenium/remote/tracing/opentelemetry",
"//java/src/org/openqa/selenium/support/decorators",
Expand Down
2 changes: 1 addition & 1 deletion java/src/org/openqa/selenium/remote/http/HttpClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ static Factory create(String name) {
* <p>{@see create}
*/
static Factory createDefault() {
return create(System.getProperty("webdriver.http.factory", "netty"));
return create("jdk-http-client");
}

/**
Expand Down
15 changes: 5 additions & 10 deletions java/src/org/openqa/selenium/remote/http/jdk/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
load("//java:defs.bzl", "java_export")
load("//java:version.bzl", "SE_VERSION")
load("@rules_jvm_external//:defs.bzl", "artifact")
load("//java:defs.bzl", "java_library")

java_export(
java_library(
name = "jdk",
srcs = glob(["*.java"]),
javacopts = [
"--release",
"11", # Deliberately targeting Java 11 for widest possible support
],
maven_coordinates = "org.seleniumhq.selenium:selenium-http-jdk-client:%s" % SE_VERSION,
pom_template = "//java/src/org/openqa/selenium:template-pom",
visibility = [
"//visibility:public",
"//java/src/org/openqa/selenium/remote:__pkg__",
"//java/test/org/openqa/selenium/remote/http:__subpackages__",
],
deps = [
"//java:auto-service",
Expand Down
31 changes: 0 additions & 31 deletions java/src/org/openqa/selenium/remote/http/netty/BUILD.bazel

This file was deleted.

127 changes: 0 additions & 127 deletions java/src/org/openqa/selenium/remote/http/netty/NettyClient.java

This file was deleted.

Loading

0 comments on commit 7c14bff

Please sign in to comment.