update code as suggestions

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
SeleniumHQ · Apr 12, 2024 · d5971ea · d5971ea
1 parent a73ba2f
commit d5971ea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/java/src/org/openqa/selenium/docker/ContainerConfig.java b/java/src/org/openqa/selenium/docker/ContainerConfig.java
@@ -53,7 +53,15 @@ public ContainerConfig(
  List<Device> devices,
  String networkName,
  long shmSize) {
- this(image, portBindings, envVars, volumeBinds, devices, networkName, shmSize, new HashMap<>());
+ this(
+ image,
+ portBindings,
+ envVars,
+ volumeBinds,
+ devices,
+ networkName,
+ shmSize,
+ ImmutableMap.of());
  }
 
  public ContainerConfig(
@@ -73,7 +81,7 @@ public ContainerConfig(
  this.networkName = networkName;
  this.autoRemove = true;
  this.shmSize = shmSize;
- this.hostConfig = hostConfig;
+ this.hostConfig = hostConfig != null ? hostConfig : ImmutableMap.of();
  }
 
  public static ContainerConfig image(Image image) {
@@ -138,7 +146,7 @@ public ContainerConfig devices(List<Device> devices) {
  image, portBindings, envVars, volumeBinds, devices, networkName, shmSize);
  }
 
- public ContainerConfig getHostConfig(Map<String, Object> hostConfig, List<String> configKeys) {
+ public ContainerConfig applyHostConfig(Map<String, Object> hostConfig, List<String> configKeys) {
  Map<String, Object> setHostConfig =
  configKeys.stream()
  .filter(hostConfig::containsKey)

diff --git a/java/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java b/java/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java
@@ -294,7 +294,7 @@ private Container createBrowserContainer(
  .shmMemorySize(browserContainerShmMemorySize)
  .network(networkName)
  .devices(devices)
- .getHostConfig(hostConfig, hostConfigKeys);
+ .applyHostConfig(hostConfig, hostConfigKeys);
  if (!runningInDocker) {
  containerConfig = containerConfig.map(Port.tcp(4444), Port.tcp(port));
  }