[🐛 Bug]: DevTools.createSession() picks a wrong window

[asolntsev]

What happened?

I have a browser with 2+ open windows (tabs).
When I execute driver.getDevTools().createSession() it connects to a wrong tab.
See the code sample below.

The problematic code is https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/devtools/DevTools.java#L99:

    // Grab the first "page" type, and glom on to that.
    // TODO: Find out which one might be the current one
    TargetID targetId = infos.stream()
      .filter(info -> "page".equals(info.getType()))
      .map(TargetInfo::getTargetId)
      .findAny()
      .orElseThrow(() -> new DevToolsException("Unable to find target id of a page"));

Actually, we can easily pick the right TargetID by matching it with WebDriver.getWindowHandle().

How can we reproduce the issue?

@Test
  void useDevToolsInWrongWindow() {
    WebDriverManager.chromedriver().setup();
    ChromeDriver driver = new ChromeDriver();
    driver.navigate().to("https://duckduckgo.com");
    driver.executeScript("window.open()");

    DevTools devTools = driver.getDevTools();
    devTools.createSessionIfThereIsNotOne();
    devTools.send(Emulation.setAutoDarkModeOverride(Optional.of(true)));

    // Expected: the first window (duckduckgo.com) becomes dark
    // Actual: the second window (empty) becomes dark
    driver.quit();
  }

The fix

Here is my pull request: #10811

Operating System

MacOS (no matter)

Selenium version

4.3.0 Java

What are the browser(s) and version(s) where you see this issue?

Chrome 102 (no matter)

What are the browser driver(s) and version(s) where you see this issue?

ChromeDriver 102 (no matter)

Are you using Selenium Grid?

no matter

[github-actions]

@asolntsev, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[diemol]

PR has been merged, thank you, @asolntsev!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.