[🐛 Bug]: Builder.forBrowser(Browser.INTERNET_EXPLORER) not use selenium-manager

[cbl980226]

What happened?

new Builder().forBrowser(Browser.INTERNET_EXPLORER).build()

not trying Selenium Manager

(seleniumManager.driverLocation)[https://github.com/SeleniumHQ/selenium/blob/634d19acf1274276f40533f4a1243adf2d1be8fb/javascript/node/selenium-webdriver/common/seleniumManager.js#L66] can't get ie driver location

How can we reproduce the issue?

mkdir tests
cd tests
npm init -y
npm add -D selenium-webdriver
touch webdriver.test.js
node webdriver.test.js

webdriver.test.js

const { Browser, Builder, By } = require('selenium-webdriver');

(async () => {
  // const driver = await new Builder().forBrowser(Browser.CHROME).build();
  const driver = await new Builder().forBrowser(Browser.INTERNET_EXPLORER).build();
  await driver.get('https://www.selenium.dev/selenium/web/web-form.html');
  const textBox = await driver.findElement(By.name('my-text'));
  const submitButton = await driver.findElement(By.css('button'));

  await textBox.sendKeys('Selenium');
  await submitButton.click();
  await driver.quit();
})();

Relevant log output

$ node webdriver.test.js
The IEDriverServer.exe executable could not be found on the current PATH,
trying Selenium Manager
Unable to obtain driver using Selenium Manager: Error: Unable to locate dr
iver associated with browser name: internet explorer

Operating System

Windows 10

Selenium version

Node selenium-webdriver@4.8.0

What are the browser(s) and version(s) where you see this issue?

None

What are the browser driver(s) and version(s) where you see this issue?

None

Are you using Selenium Grid?

No response

[github-actions]

@cbl980226, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[diemol]

Is this still happening with 4.8.0?

[cbl980226]

Is this still happening with 4.8.0?

Yes, I tried it with 4.8.0 version using the example above , it still happens.

driverLocation(Browser.INTERNET_EXPLORER) not allowed

https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/ie.js#L409

  if (!exe) {
    console.log(
      `The ${IEDRIVER_EXE} executable could not be found on the current PATH, trying Selenium Manager`
    )

    try {
      exe = driverLocation(Browser.INTERNET_EXPLORER)
    } catch (err) {
      console.log(`Unable to obtain driver using Selenium Manager: ${err}`)
    }
  }

https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/common/seleniumManager.js#L65

/**
 * currently supported browsers for selenium-manager
 * @type {string[]}
 */
const Browser = ['chrome', 'firefox', 'edge']

function driverLocation(browser) {
  if (!Browser.includes(browser.toLocaleString())) {
    throw new Error(
      `Unable to locate driver associated with browser name: ${browser}`
    )
  }
 }

[diemol]

Are you behind a proxy?

[cbl980226]

Are you behind a proxy?

Yes I use the clash proxy

[diemol]

OK, this is not supported yet. This PR implements it #11575, and we should be able to release in a couple of weeks.

[cbl980226]

Sorry, I think maybe not proxy problem.

selenium-manager.exe is work for me with proxy.

I created a repository => https://github.com/cbl980226/selenium-manager-test

I only change driverLocation:
https://github.com/cbl980226/selenium-manager-test/blob/master/selenium-manager.js#L59
https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/common/seleniumManager.js#L66

[diemol]

@bonigarcia could you please help us to check this?

[bonigarcia]

I think the Selenium JavaScript binding should support IExplorer as well, since Selenium Manager already does. If I am not wrong, in this line:

https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/common/seleniumManager.js#L33

... it seems that the JavaScript binding does not supports IExplorer yet.

[diemol]

Good point. Thanks @bonigarcia!

@harsha509, is this a matter of adding iexplorer to that array?

[titusfortner]

For next version of Selenium, we are hopefully moving to parsing the options instance for browser name and browser version and not using the driver name.

[harsha509]

Looks like a diff issue, if IEDriver not found, JS binding send internet explorer to selenium-manager instead of iexplorer!

Fixed with above commit. tested in windows machine!

[harsha509]

Good point. Thanks @bonigarcia!

@harsha509, is this a matter of adding iexplorer to that array?

Also, added iexplorer into array!

Thank you @diego, @titusfortner !