-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWP Actions #10215
JWP Actions #10215
Conversation
SonarCloud Quality Gate failed. |
4ac27a5
to
359123b
Compare
I was previously concerned that these changes were going to break OSS -> W3C backwards compatibility, but I build grid with this branch and ran tests with Selenium 2.53 and everything seems to work still... If tests are passing, I say we merge it. |
never mind, this is not passing the old Selenium 2.53 tests. I think we should decide #10374 before we merge this. |
SonarCloud Quality Gate failed. |
Merged first bit of this PR through e3089c9 |
Codecov Report
@@ Coverage Diff @@
## trunk #10215 +/- ##
==========================================
+ Coverage 44.97% 48.20% +3.23%
==========================================
Files 85 86 +1
Lines 5479 5570 +91
Branches 269 279 +10
==========================================
+ Hits 2464 2685 +221
+ Misses 2746 2606 -140
- Partials 269 279 +10
Continue to review full report at Codecov.
|
Second part was merged as 4dcc9c4. Overall, we could not delete all the code because it was being referenced from the old server used for RC. So what I did was to move the deprecated code that could not be deleted over there, even if we are not releasing RC anymore, we are keeping the code for a while. We will delete that in some months, if no issues arise. |
This is slightly less ambitious than #10203
I broke it up into 2 commits.
The first removes support for the things deprecated in 6b8bdae (1/7/2017) for selenium-3.1.0
The second removes support for the things deprecated in e561ca8 (10/29/2018) for selenium-3.141.0
I essentially deleted the deprecated classes and then removed everything that referenced them.
The biggest difference from the other commit is that I didn't touch any of the abandoned commands in
DriverCommand.java
which I think we can dramatically clean up in another commit.One issue with this is that we did not deprecate
TouchActions.java
. I think the intention was to implement it with w3c compliant methods, but... because it is a subclass, we'd either need to add generics, make a bunch of private methods public, or add these methods toActions.java
directly. As it is, this implementation is not usable, so I think it should be removed for now, and we should add the touch actions in theActions.java
class directly, which I think we should do with ScrollWheel as well.