Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWP Actions #10215

Closed
wants to merge 2 commits into from
Closed

Conversation

titusfortner
Copy link
Member

This is slightly less ambitious than #10203

I broke it up into 2 commits.
The first removes support for the things deprecated in 6b8bdae (1/7/2017) for selenium-3.1.0
The second removes support for the things deprecated in e561ca8 (10/29/2018) for selenium-3.141.0

I essentially deleted the deprecated classes and then removed everything that referenced them.

The biggest difference from the other commit is that I didn't touch any of the abandoned commands in DriverCommand.java which I think we can dramatically clean up in another commit.

One issue with this is that we did not deprecate TouchActions.java. I think the intention was to implement it with w3c compliant methods, but... because it is a subclass, we'd either need to add generics, make a bunch of private methods public, or add these methods to Actions.java directly. As it is, this implementation is not usable, so I think it should be removed for now, and we should add the touch actions in the Actions.java class directly, which I think we should do with ScrollWheel as well.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@titusfortner titusfortner marked this pull request as draft February 3, 2022 17:53
@titusfortner
Copy link
Member Author

I was previously concerned that these changes were going to break OSS -> W3C backwards compatibility, but I build grid with this branch and ran tests with Selenium 2.53 and everything seems to work still... If tests are passing, I say we merge it.

@titusfortner titusfortner marked this pull request as ready for review February 24, 2022 17:21
@titusfortner
Copy link
Member Author

never mind, this is not passing the old Selenium 2.53 tests. I think we should decide #10374 before we merge this.

@titusfortner titusfortner marked this pull request as draft February 24, 2022 17:30
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@titusfortner titusfortner added this to the 4.3 milestone May 24, 2022
@diemol
Copy link
Member

diemol commented Jun 10, 2022

Merged first bit of this PR through e3089c9

@codecov-commenter
Copy link

Codecov Report

Merging #10215 (e3089c9) into trunk (e8e9389) will increase coverage by 3.23%.
The diff coverage is n/a.

❗ Current head e3089c9 differs from pull request most recent head 359123b. Consider uploading reports for the commit 359123b to get more accurate results

@@            Coverage Diff             @@
##            trunk   #10215      +/-   ##
==========================================
+ Coverage   44.97%   48.20%   +3.23%     
==========================================
  Files          85       86       +1     
  Lines        5479     5570      +91     
  Branches      269      279      +10     
==========================================
+ Hits         2464     2685     +221     
+ Misses       2746     2606     -140     
- Partials      269      279      +10     
Impacted Files Coverage Δ
.../selenium/webdriver/support/expected_conditions.py 26.39% <0.00%> (-6.79%) ⬇️
py/selenium/webdriver/remote/switch_to.py 34.09% <0.00%> (-1.47%) ⬇️
...lenium/webdriver/common/actions/pointer_actions.py 20.83% <0.00%> (-0.86%) ⬇️
py/selenium/webdriver/remote/webdriver.py 38.98% <0.00%> (-0.71%) ⬇️
py/selenium/webdriver/chromium/webdriver.py 53.48% <0.00%> (-0.54%) ⬇️
py/selenium/webdriver/ie/webdriver.py 64.78% <0.00%> (-0.49%) ⬇️
py/selenium/types.py 100.00% <0.00%> (ø)
py/selenium/common/__init__.py 100.00% <0.00%> (ø)
py/selenium/webdriver/__init__.py 100.00% <0.00%> (ø)
py/selenium/webdriver/remote/command.py 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e9389...359123b. Read the comment docs.

@diemol
Copy link
Member

diemol commented Jun 10, 2022

Second part was merged as 4dcc9c4.

Overall, we could not delete all the code because it was being referenced from the old server used for RC. So what I did was to move the deprecated code that could not be deleted over there, even if we are not releasing RC anymore, we are keeping the code for a while. We will delete that in some months, if no issues arise.

@diemol diemol closed this Jun 10, 2022
@titusfortner titusfortner deleted the java_jwp_actions branch December 4, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants