Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Feature 11688 custom cache path #11840

Closed
wants to merge 2 commits into from
Closed

[rust] Feature 11688 custom cache path #11840

wants to merge 2 commits into from

Conversation

iampopovich
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

according to request #11688 I've added a config file to store the custom path to the cache folder. it may contain any other custom paths on demand

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@bonigarcia bonigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the logic related to const STORAGE_CONFIG_FILE: &str = ".selenium-files.json"; should not be in this PR. The configuration file is already implemented in other PR (see #11810).

@iampopovich
Copy link
Contributor Author

iampopovich commented Apr 2, 2023

@bonigarcia thanks
I’ll use implemented configuration in #11810 and let you know

@iampopovich iampopovich closed this Apr 2, 2023
@iampopovich iampopovich deleted the feature-11688 branch April 4, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants