Skip to content

[dotnet] Fix continueResponse method in CDP #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[dotnet] Fix continueResponse method in CDP #12445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab2517
Fix continueResponse method in CDP
nvborisenko Jul 30, 2023
547c250
Merge branch 'trunk' into continue-response-patch
diemol Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/DevTools/Network.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public async Task SetUserAgentOverride(string userAgent)
public abstract Task AddResponseBody(HttpResponseData responseData);

/// <summary>
/// Asynchronously contines an intercepted network response without modification.
/// Asynchronously continues an intercepted network response without modification.
/// </summary>
/// <param name="responseData">The <see cref="HttpResponseData"/> of the network response.</param>
/// <returns>A task that represents the asynchronous operation.</returns>
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/DevTools/v113/V113Network.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ public override async Task AddResponseBody(HttpResponseData responseData)
}

/// <summary>
/// Asynchronously contines an intercepted network response without modification.
/// Asynchronously continues an intercepted network response without modification.
/// </summary>
/// <param name="responseData">The <see cref="HttpResponseData"/> of the network response.</param>
/// <returns>A task that represents the asynchronous operation.</returns>
public override async Task ContinueResponseWithoutModification(HttpResponseData responseData)
{
await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = responseData.RequestId });
await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId });
}

private void OnFetchAuthRequired(object sender, Fetch.AuthRequiredEventArgs e)
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/DevTools/v114/V114Network.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ public override async Task AddResponseBody(HttpResponseData responseData)
}

/// <summary>
/// Asynchronously contines an intercepted network response without modification.
/// Asynchronously continues an intercepted network response without modification.
/// </summary>
/// <param name="responseData">The <see cref="HttpResponseData"/> of the network response.</param>
/// <returns>A task that represents the asynchronous operation.</returns>
public override async Task ContinueResponseWithoutModification(HttpResponseData responseData)
{
await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = responseData.RequestId });
await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId });
}

private void OnFetchAuthRequired(object sender, Fetch.AuthRequiredEventArgs e)
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/DevTools/v115/V115Network.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,13 @@ public override async Task AddResponseBody(HttpResponseData responseData)
}

/// <summary>
/// Asynchronously contines an intercepted network response without modification.
/// Asynchronously continues an intercepted network response without modification.
/// </summary>
/// <param name="responseData">The <see cref="HttpResponseData"/> of the network response.</param>
/// <returns>A task that represents the asynchronous operation.</returns>
public override async Task ContinueResponseWithoutModification(HttpResponseData responseData)
{
await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = responseData.RequestId });
await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId });
}

private void OnFetchAuthRequired(object sender, Fetch.AuthRequiredEventArgs e)
Expand Down