Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Remove Microsoft.IdentityModel.Tokens as dependency #12777

Merged
merged 9 commits into from
Sep 25, 2023
Merged

[dotnet] Remove Microsoft.IdentityModel.Tokens as dependency #12777

merged 9 commits into from
Sep 25, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 19, 2023 •
edited
Loading

Description

We can remove Microsoft.IdentityModel.Tokens dependency.

What is done:

  • Adopted small piece code what we need
  • Remove everything related to Microsoft.IdentityModel.Tokens

Original source: https://raw.githubusercontent.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/6.19.0/src/Microsoft.IdentityModel.Tokens/Base64UrlEncoder.cs

Motivation and Context

Ideally any library should not have dependencies.
Related to #12692

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko mentioned this pull request Sep 19, 2023
Merged
8 tasks
titusfortner
titusfortner requested changes Sep 24, 2023
View reviewed changes
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, will be nice to remove the dependency.

dotnet/src/webdriver/Internal/Base64UrlEncoder.cs Outdated Show resolved Hide resolved
dotnet/src/webdriver/Internal/Base64UrlEncoder.cs Outdated Show resolved Hide resolved
dotnet/src/webdriver/Internal/Base64UrlEncoder.cs Outdated Show resolved Hide resolved
dotnet/src/webdriver/Internal/Base64UrlEncoder.cs Show resolved Hide resolved
@titusfortner titusfortner merged commit b884044 into SeleniumHQ:trunk Sep 25, 2023
12 of 13 checks passed
@nvborisenko nvborisenko deleted the dotnet-dep-identitymodel branch November 10, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titusfortner titusfortner Awaiting requested review from titusfortner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvborisenko @titusfortner