[java] Self-signed certificate should not require certificate file

[pujagani]

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

When using Grid with --self-signed-https option, it throws an error that "You must provide a certificate via --https-certificate when using --https ". It is not required when using self-signed. The error occurred during the check at the step
https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/grid/security/SecretOptions.java#L44.

The easiest solution was to remove the check however that might not be the right solution since I do not have the context of why it was added here and if/why registration secret is required for this case too.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (240e17b) 57.53% compared to head (bcb2f5a) 57.95%.
Report is 61 commits behind head on trunk.

❗ Current head bcb2f5a differs from pull request most recent head 45a12c9. Consider uploading reports for the commit 45a12c9 to get more accurate results

Files	Patch %	Lines
py/selenium/webdriver/safari/webdriver.py	50.00%	3 Missing ⚠️
py/selenium/webdriver/chromium/webdriver.py	83.33%	1 Missing and 1 partial ⚠️
py/selenium/webdriver/firefox/remote_connection.py	0.00%	1 Missing ⚠️
py/selenium/webdriver/firefox/webdriver.py	83.33%	1 Missing ⚠️
py/selenium/webdriver/ie/webdriver.py	87.50%	1 Missing ⚠️
py/selenium/webdriver/remote/webdriver.py	66.66%	1 Missing ⚠️
py/selenium/webdriver/safari/service.py	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #13268      +/-   ##
==========================================
+ Coverage   57.53%   57.95%   +0.42%     
==========================================
  Files          86       88       +2     
  Lines        5310     5333      +23     
  Branches      221      224       +3     
==========================================
+ Hits         3055     3091      +36     
+ Misses       2034     2018      -16     
- Partials      221      224       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[VietND96]

@pujagani, I am just aware that in #13413 I added back the check || isSelfSigned(). This mistake caused this fix to be reverted. Can you please recommit if this is a major impact? Thanks!

[pujagani]

Sure! Will do that. Appreciate your help! Thank you

[VietND96]

Thank you @pujagani !
I saw the recommit come to the trunk already. Can we consider releasing new jar package for the selenium grid together with the Python binding fix also? @diemol

[diemol]

Not really, is this urgent and needs a patch release?

[VietND96]

Not really, is this urgent and needs a patch release?

I think not urgent, we can wait for 4.18.0