-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build] Archive Selenium Manager Binaries #13314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb10299 to
30b76f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13314 +/- ##
=======================================
Coverage 58.05% 58.05%
=======================================
Files 88 88
Lines 5338 5338
Branches 224 224
=======================================
Hits 3099 3099
Misses 2015 2015
Partials 224 224 ☔ View full report in Codecov by Sentry. |
diemol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty good, thank you @titusfortner!
I think building on every commit is fine, given that it does not change a lot.
30b76f5 to
3033826
Compare
|
Ok, I've updated the repo names to point to https://github.com/SeleniumHQ/selenium_manager_snapshots/ (the releases there were automatically generated by Selenium's CI). I've moved the CI code from |
061d851 to
11bdec9
Compare
11bdec9 to
cf8b23f
Compare
|
I had this working, then I tweaked something and now it isn't deploying. At least it is passing RBE now. Once I figure out why it isn't releasing the binaries any more, I'll merge this. |
|
Ok, this makes sense. It wasn't working as a PR because of tokens, but when I run this code as a Selenium branch, it works — https://github.com/SeleniumHQ/selenium/actions/runs/7331186361 |
Status
This is in Draft because it is using my fork to demo the proof of concept.
This Git Hub Actions Run — https://github.com/titusfortner/selenium/actions/runs/7219076550
Made this commit — titusfortner/selenium_manager_debug@fab2d26
And did this release — https://github.com/titusfortner/selenium_manager_debug/releases/tag/selenium-manager-fab2d26
Description
pinned_browsersinstead ofstamp(the way I'm skipping downloading is definitely hacky, there is probably a better way)selenium_manager.pyfile very similar topinned_browsers.pyto update the url and hash for the latest version of binariesMotivation and Context
Future Considerations
Makebuild-selenium-manager.ymlpart ofci-rust.ymlhttp_fileworking before I could figure out how to gethttp_archiveworking