Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] WebSocket NoVNC session against the grid URL contains trailing slash #13353

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 22, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

[java] WebSocket NoVNC session against the grid URL contains trailing slash

Motivation and Context

We are going to the situation when --grid-url contains trailing slash, e.g. http://my.domain.com/
Based on the grid URL, others NoVNC, CDP, BiDi urls are constructed with double-slash http://my.domain.com//session, which caused a redirect issue (mentioned in SeleniumHQ/docker-selenium#2075)
Users no longer have to worry about the trailing slash.
Fix: SeleniumHQ/docker-selenium#2075

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… slash

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64d9c87) 58.05% compared to head (4b0e63d) 58.05%.
Report is 3 commits behind head on trunk.

❗ Current head 4b0e63d differs from pull request most recent head 56c8fea. Consider uploading reports for the commit 56c8fea to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13353   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          88       88           
  Lines        5338     5338           
  Branches      224      224           
=======================================
  Hits         3099     3099           
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit 55d735b into SeleniumHQ:trunk Dec 22, 2023
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: VNC viewer issue in Kubernetes with nginx ingress extra / in wss URL
3 participants