Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use JDK 17 #13823

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

Trigtrig
Copy link
Contributor

@Trigtrig Trigtrig commented Apr 15, 2024

User description

Description

Update Dockerfile to use JDK 17

Fixes #13731

Motivation and Context

Fixes #13731

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Type

enhancement


Description

  • Updated the Dockerfile to use OpenJDK 17 instead of OpenJDK 11, aligning with the latest JDK standards and providing enhanced features and performance improvements.

Changes walkthrough

Relevant files
Enhancement
Dockerfile
Update JDK Version in Dockerfile to JDK 17                             

scripts/dev-image/Dockerfile

  • Updated the base JDK from version 11 to 17 in the Dockerfile.
+1/-1     

PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Description updated to latest commit (2d918c5)

Copy link

PR Review

⏱️ Estimated effort to review [1-5]

1, because the change is straightforward and only involves updating the JDK version in the Dockerfile.

🧪 Relevant tests

No

🔍 Possible issues

Compatibility Issue: Ensure that all applications and dependencies are compatible with JDK 17 to avoid runtime issues.

🔒 Security concerns

No


✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

  • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

Copy link

PR Code Suggestions

CategorySuggestions                                                                                                                                                       
Best practice
Pin the version of openjdk-17-jdk to ensure consistent builds.

Consider pinning the version of openjdk-17-jdk to ensure consistent, repeatable builds.
Using a specific version helps avoid unexpected changes when newer versions are released.
For example, instead of openjdk-17-jdk, specify openjdk-17-jdk=17.0.2-1.

scripts/dev-image/Dockerfile [20]

-openjdk-17-jdk
+openjdk-17-jdk=17.0.2-1
 

✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

  • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Trigtrig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Selenium build project Docker script update
2 participants