Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Return and deprecate DriverFinder.path #13877

Closed
wants to merge 1 commit into from
Closed

Conversation

p0deje
Copy link
Member

@p0deje p0deje commented Apr 25, 2024

User description

This was accidentally removed in #13386.
Fixes #13876.
Related to rails/rails#51658.

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Type

Bug fix, Enhancement


Description

  • Reintroduced and deprecated the DriverFinder.path method which was previously removed, now redirecting to new.driver_path.
  • Changed the access of driver_path and EXECUTABLE from class-based to instance-based to ensure proper encapsulation and adherence to object-oriented principles.

Changes walkthrough

Relevant files
Enhancement
driver_finder.rb
Add Deprecated path Method and Refactor Access Patterns in
DriverFinder

rb/lib/selenium/webdriver/common/driver_finder.rb

  • Added a deprecated method path to DriverFinder class.
  • Updated the method to use new.driver_path instead of directly
    accessing the driver path.
  • Modified internal usage of driver_path and EXECUTABLE to use
    instance-based access rather than class-based.
  • +7/-2     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Description updated to latest commit (0a83b47)

    Copy link
    Contributor

    PR Review

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are localized and straightforward, involving the reintroduction and deprecation of a method, and minor modifications to variable access within a class.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Possible Bug: The reintroduction of DriverFinder.path might not handle all edge cases if new(options, service).driver_path behaves differently than the original implementation. It's important to ensure that this method redirection is fully compatible with all expected use cases.

    🔒 Security concerns

    No


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    
    [pr_reviewer]
    some_config1=...
    some_config2=...
    

    See the review usage page for a comprehensive guide on using this tool.

    Copy link
    Contributor

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Maintainability
    Improve encapsulation by replacing direct constant access with a method call.

    Replace the direct access to @service::EXECUTABLE with a method call to ensure
    encapsulation and maintainability. Direct access to constants from another class's
    instance variable can lead to tight coupling and potential issues if the class definition
    changes.

    rb/lib/selenium/webdriver/common/driver_finder.rb [51]

    -exe = @service::EXECUTABLE
    +exe = @service.executable
     
    Robustness
    Add error handling to ensure the driver path is valid.

    Ensure that the driver_path method in the DriverFinder class handles the case where
    new(options, service).driver_path returns nil or an invalid path, possibly by adding error
    handling or a fallback mechanism.

    rb/lib/selenium/webdriver/common/driver_finder.rb [25]

    -new(options, service).driver_path
    +path = new(options, service).driver_path
    +raise 'Invalid driver path' if path.nil? || !File.exist?(path)
    +path
     
    Prevent runtime errors by checking if path is callable.

    Add a check to ensure that path is callable before attempting to call it, to prevent
    potential NoMethodError if path is not a Proc.

    rb/lib/selenium/webdriver/common/driver_finder.rb [50]

    -path = path.call if path.is_a?(Proc)
    +path = path.call if path.respond_to?(:call)
     
    Performance
    Improve performance by caching the result of the driver path computation.

    Consider caching the result of new(options, service).driver_path if it's computationally
    expensive or if DriverFinder.path is called frequently, to improve performance.

    rb/lib/selenium/webdriver/common/driver_finder.rb [25]

    -new(options, service).driver_path
    +@@driver_path ||= new(options, service).driver_path
     
    Enhancement
    Enhance the deprecation warning to provide more detailed guidance.

    Refactor the deprecation warning in DriverFinder.path to include more details about the
    deprecation timeline or alternative recommendations, providing clearer guidance to
    developers.

    rb/lib/selenium/webdriver/common/driver_finder.rb [24]

    -WebDriver.logger.deprecate('DriverFinder.path', 'DriverFinder.new.driver_path')
    +WebDriver.logger.deprecate('DriverFinder.path', 'DriverFinder.new.driver_path', 'This method will be removed in version 4.0. Please use DriverFinder.new.driver_path instead.')
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    
    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    

    See the improve usage page for a comprehensive guide on using this tool.

    Copy link
    Contributor

    codiumai-pr-agent-pro bot commented Apr 25, 2024

    CI Failure Feedback

    (Checks updated until commit bc20b11)

    Action: Ruby / Local Tests (chrome, macos) / Local Tests (chrome, macos)

    Failed stage: Run Bazel [❌]

    Failed test name: //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome

    Failure summary:

    The action failed due to multiple test failures in the
    //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome test suite. The primary issues
    identified include failures in executing asynchronous scripts, navigating to specific URLs, and
    removing virtual authenticators. These failures are likely related to issues with the Selenium
    WebDriver's interactions with the Chrome browser, possibly due to timeouts, incorrect script
    executions, or unresponsive elements.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  macOS
    ...
    
    869:  �[32m[1,872 / 1,895]�[0m Testing //rb/spec/integration/selenium/webdriver:takes_screenshot-chrome; 7s local, disk-cache ... (3 actions, 2 running)
    870:  �[32m[1,873 / 1,895]�[0m 1 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 8s ... (3 actions, 1 running)
    871:  �[32m[1,873 / 1,895]�[0m 1 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 9s ... (3 actions, 1 running)
    872:  �[32m[1,873 / 1,895]�[0m 1 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:timeout-chrome; 11s local, disk-cache ... (3 actions, 2 running)
    873:  �[32m[1,874 / 1,895]�[0m 2 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:navigation-chrome; 10s ... (3 actions, 1 running)
    874:  �[32m[1,874 / 1,895]�[0m 2 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:navigation-chrome; 11s ... (3 actions, 1 running)
    875:  �[32m[1,874 / 1,895]�[0m 2 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:navigation-chrome; 21s ... (3 actions, 1 running)
    876:  �[32m[1,874 / 1,895]�[0m 2 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:driver-chrome; 28s local, disk-cache ... (3 actions, 2 running)
    877:  �[32m[1,875 / 1,895]�[0m 3 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:error-chrome; 27s ... (3 actions, 1 running)
    878:  �[32m[1,875 / 1,895]�[0m 3 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:error-chrome; 28s ... (3 actions, 1 running)
    879:  �[32m[1,876 / 1,895]�[0m 4 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:listener-chrome ... (3 actions, 1 running)
    880:  �[32m[1,876 / 1,895]�[0m 4 / 27 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:listener-chrome ... (3 actions, 1 running)
    881:  �[32m[1,876 / 1,895]�[0m 4 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome; 2s local, disk-cache ... (3 actions, 2 running)
    ...
    
    941:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2138s local, disk-cache ... (3 actions, 1 running)
    942:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2204s local, disk-cache ... (3 actions, 1 running)
    943:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2270s local, disk-cache ... (3 actions, 1 running)
    944:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2337s local, disk-cache ... (3 actions, 1 running)
    945:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2404s local, disk-cache ... (3 actions, 1 running)
    946:  �[32m[1,884 / 1,895]�[0m 12 / 27 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome; 2426s local, disk-cache ... (3 actions, 2 running)
    947:  �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/virtual_authenticator-chrome/test.log)
    948:  ==================== Test output for //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome:
    949:  �[31m�[1mFAILED: �[0m//rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome (Summary)
    ...
    
    958:  driver: chrome
    959:  version: 124.0.6367.62
    960:  platform: macosx
    961:  ci: github
    962:  ruby: ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [arm64-darwin23]
    963:  .....FFFFFFFFF
    964:  Failures:
    965:  1) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident ctap
    966:  Got 0 failures and 2 other errors:
    967:  1.1) Failure/Error: driver.execute_async_script(script, id)
    ...
    
    970:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    971:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    972:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    973:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    974:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:338:in `execute_async_script'
    975:  # ./rb/lib/selenium/webdriver/common/driver.rb:244:in `execute_async_script'
    976:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:76:in `credential'
    977:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:136:in `block (3 levels) in <module:WebDriver>'
    978:  1.2) Failure/Error: after { @authenticator&.remove! if @authenticator&.valid? }
    ...
    
    981:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    982:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    983:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    984:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    985:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:559:in `remove_virtual_authenticator'
    986:  # ./rb/lib/selenium/webdriver/common/virtual_authenticator/virtual_authenticator.rb:63:in `remove!'
    987:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:56:in `block (2 levels) in <module:WebDriver>'
    988:  2) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident u2f
    989:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    992:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    993:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    994:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    995:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    996:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    997:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    998:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    999:  3) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident ctap
    1000:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1003:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1004:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1005:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1006:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1007:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1008:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1009:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1010:  4) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident u2f
    1011:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1014:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1015:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1016:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1017:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1018:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1019:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1020:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1021:  5) Selenium::WebDriver::VirtualAuthenticator#credentials gets multiple
    1022:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1025:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1026:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1027:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1028:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1029:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1030:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1031:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1032:  6) Selenium::WebDriver::VirtualAuthenticator#remove_credential by raw ID
    1033:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1036:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1037:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1038:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1039:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1040:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1041:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1042:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1043:  7) Selenium::WebDriver::VirtualAuthenticator#remove_credential by encoded ID
    1044:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1047:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1048:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1049:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1050:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1051:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1052:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1053:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1054:  8) Selenium::WebDriver::VirtualAuthenticator#remove_all_credentials removes multiple
    1055:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1058:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1059:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1060:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1061:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1062:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1063:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1064:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1065:  9) Selenium::WebDriver::VirtualAuthenticator#user_verified= can not obtain credential requiring verification when set to false
    1066:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1069:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1070:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1071:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1072:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1073:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1074:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1075:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1076:  Finished in 13 minutes 33 seconds (files took 0.2622 seconds to load)
    1077:  14 examples, 9 failures
    1078:  Failed examples:
    ...
    
    1094:  driver: chrome
    1095:  version: 124.0.6367.62
    1096:  platform: macosx
    1097:  ci: github
    1098:  ruby: ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [arm64-darwin23]
    1099:  .....FFFFFFFFF
    1100:  Failures:
    1101:  1) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident ctap
    1102:  Got 0 failures and 2 other errors:
    1103:  1.1) Failure/Error: driver.execute_async_script(script, id)
    ...
    
    1106:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1107:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1108:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1109:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1110:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:338:in `execute_async_script'
    1111:  # ./rb/lib/selenium/webdriver/common/driver.rb:244:in `execute_async_script'
    1112:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:76:in `credential'
    1113:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:136:in `block (3 levels) in <module:WebDriver>'
    1114:  1.2) Failure/Error: after { @authenticator&.remove! if @authenticator&.valid? }
    ...
    
    1117:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1118:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1119:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1120:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1121:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:559:in `remove_virtual_authenticator'
    1122:  # ./rb/lib/selenium/webdriver/common/virtual_authenticator/virtual_authenticator.rb:63:in `remove!'
    1123:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:56:in `block (2 levels) in <module:WebDriver>'
    1124:  2) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident u2f
    1125:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1128:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1129:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1130:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1131:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1132:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1133:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1134:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1135:  3) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident ctap
    1136:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1139:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1140:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1141:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1142:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1143:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1144:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1145:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1146:  4) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident u2f
    1147:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1150:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1151:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1152:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1153:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1154:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1155:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1156:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1157:  5) Selenium::WebDriver::VirtualAuthenticator#credentials gets multiple
    1158:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1161:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1162:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1163:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1164:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1165:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1166:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1167:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1168:  6) Selenium::WebDriver::VirtualAuthenticator#remove_credential by raw ID
    1169:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1172:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1173:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1174:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1175:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1176:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1177:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1178:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1179:  7) Selenium::WebDriver::VirtualAuthenticator#remove_credential by encoded ID
    1180:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1183:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1184:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1185:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1186:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1187:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1188:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1189:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1190:  8) Selenium::WebDriver::VirtualAuthenticator#remove_all_credentials removes multiple
    1191:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1194:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1195:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1196:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1197:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1198:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1199:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1200:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1201:  9) Selenium::WebDriver::VirtualAuthenticator#user_verified= can not obtain credential requiring verification when set to false
    1202:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1205:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1206:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1207:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1208:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1209:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1210:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1211:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1212:  Finished in 13 minutes 13 seconds (files took 0.25902 seconds to load)
    1213:  14 examples, 9 failures
    1214:  Failed examples:
    ...
    
    1230:  driver: chrome
    1231:  version: 124.0.6367.62
    1232:  platform: macosx
    1233:  ci: github
    1234:  ruby: ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [arm64-darwin23]
    1235:  .....FFFFFFFFF
    1236:  Failures:
    1237:  1) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident ctap
    1238:  Got 0 failures and 2 other errors:
    1239:  1.1) Failure/Error: driver.execute_async_script(script, id)
    ...
    
    1242:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1243:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1244:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1245:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1246:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:338:in `execute_async_script'
    1247:  # ./rb/lib/selenium/webdriver/common/driver.rb:244:in `execute_async_script'
    1248:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:76:in `credential'
    1249:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:136:in `block (3 levels) in <module:WebDriver>'
    1250:  1.2) Failure/Error: after { @authenticator&.remove! if @authenticator&.valid? }
    ...
    
    1253:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1254:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1255:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1256:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1257:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:559:in `remove_virtual_authenticator'
    1258:  # ./rb/lib/selenium/webdriver/common/virtual_authenticator/virtual_authenticator.rb:63:in `remove!'
    1259:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:56:in `block (2 levels) in <module:WebDriver>'
    1260:  2) Selenium::WebDriver::VirtualAuthenticator#add_credential to non-resident u2f
    1261:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1264:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1265:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1266:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1267:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1268:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1269:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1270:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1271:  3) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident ctap
    1272:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1275:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1276:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1277:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1278:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1279:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1280:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1281:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1282:  4) Selenium::WebDriver::VirtualAuthenticator#add_credential to resident u2f
    1283:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1286:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1287:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1288:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1289:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1290:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1291:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1292:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1293:  5) Selenium::WebDriver::VirtualAuthenticator#credentials gets multiple
    1294:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1297:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1298:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1299:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1300:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1301:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1302:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1303:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1304:  6) Selenium::WebDriver::VirtualAuthenticator#remove_credential by raw ID
    1305:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1308:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1309:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1310:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1311:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1312:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1313:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1314:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1315:  7) Selenium::WebDriver::VirtualAuthenticator#remove_credential by encoded ID
    1316:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1319:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1320:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1321:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1322:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1323:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1324:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1325:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1326:  8) Selenium::WebDriver::VirtualAuthenticator#remove_all_credentials removes multiple
    1327:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1330:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1331:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1332:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1333:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1334:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1335:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1336:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1337:  9) Selenium::WebDriver::VirtualAuthenticator#user_verified= can not obtain credential requiring verification when set to false
    1338:  Failure/Error: before { driver.navigate.to url_for('virtual-authenticator.html') }
    ...
    
    1341:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:118:in `response_for'
    1342:  # ./rb/lib/selenium/webdriver/remote/http/default.rb:75:in `request'
    1343:  # ./rb/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
    1344:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:607:in `execute'
    1345:  # ./rb/lib/selenium/webdriver/remote/bridge.rb:96:in `get'
    1346:  # ./rb/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    1347:  # ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:54:in `block (2 levels) in <module:WebDriver>'
    1348:  Finished in 13 minutes 13 seconds (files took 0.27558 seconds to load)
    1349:  14 examples, 9 failures
    1350:  Failed examples:
    ...
    
    1353:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:152 # Selenium::WebDriver::VirtualAuthenticator#add_credential to resident ctap
    1354:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:168 # Selenium::WebDriver::VirtualAuthenticator#add_credential to resident u2f
    1355:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:184 # Selenium::WebDriver::VirtualAuthenticator#credentials gets multiple
    1356:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:205 # Selenium::WebDriver::VirtualAuthenticator#remove_credential by raw ID
    1357:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:218 # Selenium::WebDriver::VirtualAuthenticator#remove_credential by encoded ID
    1358:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:231 # Selenium::WebDriver::VirtualAuthenticator#remove_all_credentials removes multiple
    1359:  rspec ./rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb:242 # Selenium::WebDriver::VirtualAuthenticator#user_verified= can not obtain credential requiring verification when set to false
    1360:  ================================================================================
    1361:  �[32m[1,885 / 1,895]�[0m 13 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:target_locator-chrome; 793s ... (3 actions, 1 running)
    1362:  �[32m[1,885 / 1,895]�[0m 13 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:target_locator-chrome; 794s ... (3 actions, 1 running)
    1363:  �[32m[1,885 / 1,895]�[0m 13 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:service-chrome; 4s local, disk-cache ... (3 actions, 2 running)
    1364:  �[32m[1,886 / 1,895]�[0m 14 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:guard-chrome ... (3 actions, 1 running)
    1365:  �[32m[1,886 / 1,895]�[0m 14 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:guard-chrome; 4s ... (3 actions, 1 running)
    1366:  �[32m[1,886 / 1,895]�[0m 14 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:target_locator-chrome; 10s local, disk-cache ... (3 actions, 2 running)
    1367:  �[32m[1,887 / 1,895]�[0m 15 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/remote:driver-chrome; 9s ... (3 actions, 1 running)
    1368:  �[32m[1,887 / 1,895]�[0m 15 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/remote:driver-chrome; 10s ... (3 actions, 1 running)
    1369:  �[32m[1,887 / 1,895]�[0m 15 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:guard-chrome; 11s local, disk-cache ... (3 actions, 2 running)
    1370:  �[32m[1,888 / 1,895]�[0m 16 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/chrome:profile-chrome; 11s ... (3 actions, 1 running)
    1371:  �[32m[1,889 / 1,895]�[0m 17 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:action_builder-chrome ... (3 actions, 1 running)
    1372:  �[32m[1,889 / 1,895]�[0m 17 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:action_builder-chrome ... (3 actions, 1 running)
    1373:  �[32m[1,890 / 1,895]�[0m 18 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:element-chrome ... (3 actions, 1 running)
    1374:  �[32m[1,890 / 1,895]�[0m 18 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:element-chrome ... (3 actions, 1 running)
    1375:  �[32m[1,890 / 1,895]�[0m 18 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:element-chrome; 13s ... (3 actions, 1 running)
    1376:  �[32m[1,890 / 1,895]�[0m 18 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:action_builder-chrome; 15s local, disk-cache ... (3 actions, 2 running)
    1377:  �[32m[1,891 / 1,895]�[0m 19 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:shadow_root-chrome; 14s ... (3 actions, 1 running)
    1378:  �[32m[1,891 / 1,895]�[0m 19 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:shadow_root-chrome; 15s ... (3 actions, 1 running)
    1379:  �[32m[1,891 / 1,895]�[0m 19 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:shadow_root-chrome; 25s ... (3 actions, 1 running)
    1380:  �[32m[1,892 / 1,895]�[0m 20 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:select-chrome; 11s ... (3 actions, 1 running)
    1381:  �[32m[1,892 / 1,895]�[0m 20 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:select-chrome; 13s ... (3 actions, 1 running)
    1382:  �[32m[1,892 / 1,895]�[0m 20 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-chrome; 9s local, disk-cache ... (3 actions, 2 running)
    1383:  �[32m[1,893 / 1,895]�[0m 21 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 7s ... (2 actions, 1 running)
    1384:  �[32m[1,893 / 1,895]�[0m 21 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome; 5s local, disk-cache ... (2 actions running)
    1385:  �[32m[1,894 / 1,895]�[0m 22 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 1s local, disk-cache
    1386:  �[32m[1,894 / 1,895]�[0m 22 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/chrome:options-chrome; 5s local, disk-cache
    1387:  �[32m[1,895 / 1,896]�[0m 23 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:devtools-chrome
    1388:  �[32m[1,895 / 1,896]�[0m 23 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-chrome; 1s local, disk-cache
    1389:  �[32m[1,895 / 1,896]�[0m 23 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-chrome; 46s local, disk-cache
    1390:  �[32m[1,896 / 1,897]�[0m 24 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome
    1391:  �[32m[1,896 / 1,897]�[0m 24 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 1s local, disk-cache
    1392:  �[32m[1,896 / 1,897]�[0m 24 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 52s local, disk-cache
    1393:  �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/bidi/log_inspector-chrome/test_attempts/attempt_1.log)
    1394:  �[32m[1,896 / 1,897]�[0m 24 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 53s local, disk-cache
    1395:  �[32m[1,896 / 1,897]�[0m 24 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome; 75s local, disk-cache
    ...
    
    1403:  browser: chrome
    1404:  driver: chrome
    1405:  version: 124.0.6367.62
    1406:  platform: macosx
    1407:  ci: github
    1408:  ruby: ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [arm64-darwin23]
    1409:  .....F......
    1410:  Failures:
    1411:  1) Selenium::WebDriver::BiDi::LogInspector can filter javascript log at error level
    1412:  Failure/Error: log_inspector = described_class.new(driver)
    1413:  Selenium::WebDriver::Error::TimeoutError:
    ...
    
    1420:  # ./rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb:131:in `new'
    1421:  # ./rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb:131:in `block (3 levels) in <class:BiDi>'
    1422:  # /Users/runner/work/selenium/selenium/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb:154:in `create_driver!'
    1423:  # /Users/runner/work/selenium/selenium/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb:61:in `driver_instance'
    1424:  # /Users/runner/work/selenium/selenium/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb:67:in `reset_driver!'
    1425:  # /Users/runner/work/selenium/selenium/rb/spec/integration/selenium/webdriver/spec_support/helpers.rb:29:in `reset_driver!'
    1426:  # ./rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb:129:in `block (2 levels) in <class:BiDi>'
    1427:  Finished in 52 seconds (files took 0.19096 seconds to load)
    1428:  12 examples, 1 failure
    1429:  Failed examples:
    1430:  rspec ./rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb:128 # Selenium::WebDriver::BiDi::LogInspector can filter javascript log at error level
    1431:  ================================================================================
    1432:  �[32m[1,897 / 1,898]�[0m 25 / 27 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome
    1433:  �[32m[1,897 / 1,898]�[0m 25 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome; 1s local, disk-cache
    1434:  �[32m[1,897 / 1,898]�[0m 25 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome; 18s local, disk-cache
    1435:  �[32m[1,898 / 1,899]�[0m 26 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 0s disk-cache
    1436:  �[32m[1,898 / 1,899]�[0m 26 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 0s local, disk-cache
    1437:  �[32m[1,898 / 1,899]�[0m 26 / 27 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:bidi-chrome; 102s local, disk-cache
    1438:  �[32mINFO: �[0mFound 27 test targets...
    1439:  �[32mINFO: �[0mElapsed time: 2985.272s, Critical Path: 2477.23s
    1440:  �[32mINFO: �[0m1899 processes: 829 internal, 251 darwin-sandbox, 60 local, 759 worker.
    1441:  �[32mINFO: �[0mBuild completed, 1 test FAILED, 1899 total actions
    1442:  //rb/spec/integration/selenium/webdriver:action_builder-chrome           �[0m�[32mPASSED�[0m in 15.6s
    1443:  //rb/spec/integration/selenium/webdriver:bidi-chrome                     �[0m�[32mPASSED�[0m in 102.8s
    1444:  //rb/spec/integration/selenium/webdriver:devtools-chrome                 �[0m�[32mPASSED�[0m in 46.9s
    1445:  //rb/spec/integration/selenium/webdriver:driver-chrome                   �[0m�[32mPASSED�[0m in 11.8s
    1446:  //rb/spec/integration/selenium/webdriver:element-chrome                  �[0m�[32mPASSED�[0m in 13.4s
    1447:  //rb/spec/integration/selenium/webdriver:error-chrome                    �[0m�[32mPASSED�[0m in 2.9s
    ...
    
    1459:  //rb/spec/integration/selenium/webdriver:zipper-chrome                   �[0m�[32mPASSED�[0m in 3.0s
    1460:  //rb/spec/integration/selenium/webdriver/bidi:browsing_context-chrome    �[0m�[32mPASSED�[0m in 18.1s
    1461:  //rb/spec/integration/selenium/webdriver/chrome:driver-chrome            �[0m�[32mPASSED�[0m in 28.1s
    1462:  //rb/spec/integration/selenium/webdriver/chrome:options-chrome           �[0m�[32mPASSED�[0m in 5.8s
    1463:  //rb/spec/integration/selenium/webdriver/chrome:profile-chrome           �[0m�[32mPASSED�[0m in 2.4s
    1464:  //rb/spec/integration/selenium/webdriver/chrome:service-chrome           �[0m�[32mPASSED�[0m in 4.7s
    1465:  //rb/spec/integration/selenium/webdriver/remote:driver-chrome            �[0m�[32mPASSED�[0m in 2.6s
    1466:  //rb/spec/integration/selenium/webdriver/remote:element-chrome           �[0m�[32mPASSED�[0m in 4.7s
    1467:  //rb/spec/integration/selenium/webdriver/bidi:log_inspector-chrome        �[0m�[35mFLAKY�[0m, failed in 1 out of 2 in 52.7s
    1468:  Stats over 2 runs: max = 52.7s, min = 22.5s, avg = 37.6s, dev = 15.1s
    1469:  /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/bidi/log_inspector-chrome/test_attempts/attempt_1.log
    1470:  //rb/spec/integration/selenium/webdriver:virtual_authenticator-chrome    �[0m�[31m�[1mFAILED�[0m in 3 out of 3 in 814.1s
    1471:  Stats over 3 runs: max = 814.1s, min = 793.9s, avg = 800.7s, dev = 9.5s
    1472:  /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/virtual_authenticator-chrome/test.log
    1473:  /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/virtual_authenticator-chrome/test_attempts/attempt_1.log
    1474:  /Users/runner/.bazel/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/virtual_authenticator-chrome/test_attempts/attempt_2.log
    1475:  Executed 27 out of 27 tests: 26 tests pass and �[0m�[31m�[1m1 fails locally�[0m.
    1476:  There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
    1477:  �[0m
    1478:  ##[error]Process completed with exit code 3.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    This was accidentally removed in #13386.
    Fixes #13876.
    Related to rails/rails#51658.
    yahonda added a commit to yahonda/rails that referenced this pull request Apr 25, 2024
    This commit pins the selenium-webdriver` version to 4.19
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    This commit can be reverted once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    yahonda added a commit to yahonda/rails that referenced this pull request Apr 26, 2024
    This commit will not install the selenium-webdriver` version 4.20.0
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    yahonda added a commit to yahonda/rails that referenced this pull request Apr 26, 2024
    This commit will not install the selenium-webdriver` version 4.20.0
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    @p0deje
    Copy link
    Member Author

    p0deje commented Apr 26, 2024

    Merged in cf5393b

    @p0deje p0deje closed this Apr 26, 2024
    @p0deje p0deje deleted the rb-fix-driverfinder branch April 26, 2024 00:56
    fractaledmind pushed a commit to fractaledmind/rails that referenced this pull request May 13, 2024
    This commit will not install the selenium-webdriver` version 4.20.0
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    xjunior pushed a commit to xjunior/rails that referenced this pull request Jun 9, 2024
    This commit will not install the selenium-webdriver` version 4.20.0
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    jianbo pushed a commit to jianbo/fix-association-initialize-order that referenced this pull request Jul 8, 2024
    This commit will not install the selenium-webdriver` version 4.20.0
    because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
    It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 .
    
    Fix rails#51658
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [🐛 Bug]: Can't Fetch the Driver Path
    1 participant