-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Return and deprecate DriverFinder.path #13877
Conversation
PR Description updated to latest commit (0a83b47)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit bc20b11)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
This was accidentally removed in #13386. Fixes #13876. Related to rails/rails#51658.
0a83b47
to
bc20b11
Compare
This commit pins the selenium-webdriver` version to 4.19 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. This commit can be reverted once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
This commit will not install the selenium-webdriver` version 4.20.0 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
This commit will not install the selenium-webdriver` version 4.20.0 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
Merged in cf5393b |
This commit will not install the selenium-webdriver` version 4.20.0 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
This commit will not install the selenium-webdriver` version 4.20.0 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
This commit will not install the selenium-webdriver` version 4.20.0 because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional. It will be restored once the newer version of `selenium-webdriver` that includes SeleniumHQ/selenium#13877 . Fix rails#51658
User description
This was accidentally removed in #13386.
Fixes #13876.
Related to rails/rails#51658.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
Bug fix, Enhancement
Description
DriverFinder.path
method which was previously removed, now redirecting tonew.driver_path
.driver_path
andEXECUTABLE
from class-based to instance-based to ensure proper encapsulation and adherence to object-oriented principles.Changes walkthrough
driver_finder.rb
Add Deprecated
path
Method and Refactor Access Patterns inDriverFinder
rb/lib/selenium/webdriver/common/driver_finder.rb
path
toDriverFinder
class.new.driver_path
instead of directlyaccessing the driver path.
driver_path
andEXECUTABLE
to useinstance-based access rather than class-based.