-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] removed unused logger object from firefox/webdriver.py
#13892
Conversation
PR Description updated to latest commit (9019436)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13892 +/- ##
==========================================
- Coverage 58.72% 58.70% -0.02%
==========================================
Files 86 86
Lines 5298 5296 -2
Branches 226 226
==========================================
- Hits 3111 3109 -2
Misses 1961 1961
Partials 226 226 ☔ View full report in Codecov by Sentry. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Removed unused logger object from
Firefox/webdriver.py
Motivation and Context
Removed unused import
logging
andlogger
object.Types of changes
Checklist
Type
Bug fix
Description
logging
import and thelogger
object fromfirefox/webdriver.py
to clean up the code and improve maintainability.Changes walkthrough
webdriver.py
Remove Unused Logger from Firefox WebDriver
py/selenium/webdriver/firefox/webdriver.py
logging
.logger
object instantiation.