-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selenium-manager
executables to python manifest
#13998
Add selenium-manager
executables to python manifest
#13998
Conversation
PR Review 🔍
|
selenium-manager
executables to python manifest
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yuzawa-san!
Add selenium-manager artifacts to python manifest Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
User description
Description
Add the
selenium-manager
executables to the MANIFEST.in file so it gets installed correctly.Motivation and Context
The python sdist installation was not copying the
selenium-manager
executables when doing apip install /path/to/sdist
. This error was happening:selenium.common.exceptions.WebDriverException: Message: Unable to obtain working Selenium Manager binary; /tmp/testvirtualenv/lib/python3.12/site-packages/selenium/webdriver/common/macos/selenium-manager
This is not an issue in the wheel install since the bazel build automatically includes those.
However, I am forced to use the sdist (via the homebrew-pypi-poet).
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
selenium-manager
executables for Linux, macOS, and Windows to the MANIFEST.in file to ensure they are included in the Python sdist installation.selenium-manager
executables were not being copied duringpip install /path/to/sdist
, causing aWebDriverException
.Changes walkthrough 📝
MANIFEST.in
Include `selenium-manager` executables in Python sdist
py/MANIFEST.in
selenium-manager
executables for Linux, macOS, and Windows tothe MANIFEST.in file.