Add timeout and tests for curb, also added the gem curb that was not part of selenium

rb/Gemfile.lock

@@ -5,6 +5,7 @@ PATH
  selenium-webdriver (~> 4.2)
  selenium-webdriver (4.24.0.nightly)
  base64 (~> 0.2)
+ curb (~> 1.0.5)
  logger (~> 1.4)
  rexml (~> 3.2, >= 3.2.5)
  rubyzip (>= 1.2.2, < 3.0)
@@ -35,6 +36,7 @@ GEM
  bigdecimal
  rexml
  csv (3.3.0)
+ curb (1.0.5)
  debug (1.9.2)
  irb (~> 1.10)
  reline (>= 0.3.8)

rb/lib/selenium/webdriver/remote.rb

@@ -31,7 +31,8 @@ module Remote
  autoload :Capabilities, 'selenium/webdriver/remote/capabilities'
 
  module Http
- autoload :Common, 'selenium/webdriver/remote/http/common'
+ autoload :Common, 'selenium/webdriver/remote/http/common'
+ autoload :Curb, 'selenium/webdriver/remote/http/curb'
  autoload :Default, 'selenium/webdriver/remote/http/default'
  end
  end

rb/lib/selenium/webdriver/remote/http/curb.rb

@@ -37,6 +37,13 @@ module Http
  #
 
  class Curb < Common
+ attr_accessor :timeout
+
+ def initialize(timeout: nil)
+ @timeout = timeout
+ super()
+ end
+
  def quit_errors
  [Curl::Err::RecvError] + super
  end
@@ -53,7 +60,7 @@ def request(verb, url, headers, payload)
  client.headers = headers
 
  # http://github.com/taf2/curb/issues/issue/33
- client.head  = false
+ client.head = false
  client.delete = false
 
  case verb
@@ -80,15 +87,16 @@ def client
  @client ||= begin
  c = Curl::Easy.new
 
- c.max_redirects  = MAX_REDIRECTS
+ c.max_redirects = MAX_REDIRECTS
  c.follow_location = true
- c.timeout = @timeout if @timeout
- c.verbose = WebDriver.logger.debug?
-
+ c.timeout = timeout if timeout
+ c.verbose = WebDriver.logger.debug?
  c
  end
  end
- end # Curb
+ end
+
+ # Curb
  end # Http
  end # Remote
  end # WebDriver

rb/selenium-webdriver.gemspec

@@ -48,6 +48,7 @@ Gem::Specification.new do |s|
  s.require_paths = ['lib']
 
  s.add_dependency 'base64', ['~> 0.2']
+ s.add_dependency 'curb', ['~> 1.0.5']
  s.add_dependency 'logger', ['~> 1.4']
  s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5']
  s.add_dependency 'rubyzip', ['>= 1.2.2', '< 3.0']

rb/sig/gems/curb/curl.rbs

@@ -0,0 +1,5 @@
+module Curl
+ class Easy
+ def initialize: () -> void
+ end
+end

rb/sig/lib/selenium/webdriver/remote/http/curb.rbs

@@ -5,13 +5,17 @@ module Selenium
  class Curb < Common
  @client: untyped
 
- def quit_errors: () -> untyped
+ attr_accessor timeout: Numeric?
+
+ def initialize: (timeout: Numeric?) -> void
+
+ def quit_errors: () -> Array[StandardError]
 
  private
 
- def request: (untyped verb, untyped url, untyped headers, untyped payload) -> untyped
+ def request: (Symbol verb, URI | String url, Hash[String, String] headers, String payload) -> Remote::Response
 
- def client: () -> untyped
+ def client: () -> Curl::Easy
  end
  end
  end

rb/spec/unit/selenium/webdriver/remote/http/curb_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+require File.expand_path('../../spec_helper', __dir__)
+
+module Selenium
+ module WebDriver
+ module Remote
+ module Http
+ describe Curb do
+ subject(:curb) { described_class.new }
+
+ it 'assigns default timeout to 0.0' do
+ http = curb.send :client
+
+ expect(http.timeout).to eq 0.0
+ end
+
+ it 'sets the timeout' do
+ curb.timeout = 20
+ expect(curb.timeout).to eq 20
+ end
+
+ describe '#initialize' do
+ let(:curb) { described_class.new(timeout: 10) }
+
+ it 'is initialized with timeout' do
+ expect(curb.timeout).to eq 10
+ end
+ end
+ end
+ end # Http
+ end # Remote
+ end # WebDriver
+end # Selenium