-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] JSpecify annotations for wrappers #14396
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mk868!
User description
Description
In this PR I'm adding nullness annotations for interfaces:
WrapsDriver
WrapsElement
None of the methods in these wrappers can return a null value
Motivation and Context
The JSpecify nullness annotations will give developers better exposure to potential problems with their code to avoid NullPointerExceptions.
Related issue: #14291
Types of changes
Checklist
PR Type
enhancement, documentation
Description
@NullMarked
annotations to theWrapsDriver
andWrapsElement
interfaces.Changes walkthrough 📝
WrapsDriver.java
Add JSpecify nullness annotations to WrapsDriver
java/src/org/openqa/selenium/WrapsDriver.java
@NullMarked
annotation to theWrapsDriver
interface.org.jspecify.annotations.NullMarked
.WrapsElement.java
Add JSpecify nullness annotations to WrapsElement
java/src/org/openqa/selenium/WrapsElement.java
@NullMarked
annotation to theWrapsElement
interface.org.jspecify.annotations.NullMarked
.