[java] SpotBugs exclude NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
#14590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
As described in this comment, SpotBugs found some additional bugs in the code.
In this PR I fix part of the found problems.
SpotBugs errors:
documentation
Solution:
Exclude these classes from SpotBugs checks, as it is already done for
org.openqa.selenium.remote.internal.WebElementToJsonConverter
andorg.openqa.selenium.remote.WebElementToJsonConverter
classes.Motivation and Context
Fixing the actual problems is necessary before enabling full SpotBugs analysis, in order to not break the build.
Types of changes
Checklist
PR Type
bug_fix
Description
spotbugs-excludes.xml
for theNM_SAME_SIMPLE_NAME_AS_SUPERCLASS
bug pattern.org.openqa.selenium.chrome.AddHasCasting
org.openqa.selenium.chrome.AddHasCdp
org.openqa.selenium.edge.AddHasCdp
org.openqa.selenium.edge.AddHasCasting
Changes walkthrough 📝
spotbugs-excludes.xml
Exclude specific classes from SpotBugs
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
checkjava/spotbugs-excludes.xml
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
bug pattern forseveral classes.
org.openqa.selenium.chrome.AddHasCasting
from SpotBugschecks.
org.openqa.selenium.chrome.AddHasCdp
from SpotBugs checks.org.openqa.selenium.edge.AddHasCdp
andorg.openqa.selenium.edge.AddHasCasting
from SpotBugs checks.