-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add ChromiumNetworkConditions to command serialization #14716
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
@pnatashap please sign CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pnatashap !
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
fix for #14712, add class to the context for json serialization
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
ChromiumNetworkConditions
to the list of types that can be serialized to JSON in the Selenium WebDriver for .NET.Changes walkthrough 📝
Command.cs
Add ChromiumNetworkConditions to JSON serialization
dotnet/src/webdriver/Command.cs
ChromiumNetworkConditions
to JSON serialization.