-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Add Bidi Network Response Handler #14900
Open
aguspe
wants to merge
16
commits into
SeleniumHQ:trunk
Choose a base branch
from
aguspe:add_response_handler
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7ef9d83
Add response handler
aguspe 2f2012a
Update auth handlers and improve the :on method
aguspe 487a6e3
Merge branch 'trunk' into add_response_handler
aguspe 28cf363
Request and response working as expected
aguspe 314b458
Add test for continue without auth and cancel auth
aguspe 305135e
Finish implementation
aguspe ff2ba0d
Correct rubocop offenses
aguspe 0b41266
Add alias for user to do network.bidi instead of network.network
aguspe 25c201b
Fix rust file causing formatting error
aguspe 92ea3ef
Merge branch 'trunk' into add_response_handler
aguspe 7e22239
Handle requests and responses in block
aguspe ad82e86
Merge remote-tracking branch 'origin/add_response_handler' into add_r…
aguspe b2cea1d
Merge branch 'trunk' into add_response_handler
pujagani ae80832
Add ability to pass handlers to each different intercepted element
aguspe b4a4fe7
Merge remote-tracking branch 'origin/add_response_handler' into add_r…
aguspe 13a0912
Merge branch 'trunk' into add_response_handler
aguspe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Request and response working as expected
- Loading branch information
commit 28cf3635408b1db6923fec5fb915f1551d110fd3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,31 @@ def cancel_auth(request_id) | |
) | ||
end | ||
|
||
def continue_with_request(**args) | ||
response = @bidi.send_cmd( | ||
'network.continueRequest', | ||
request: args[:request_id], | ||
'body' => args[:body], | ||
'cookies' => args[:cookies], | ||
'headers' => args[:headers], | ||
'method' => args[:method], | ||
'url' => args[:url] | ||
) | ||
response.inspect | ||
end | ||
|
||
def continue_with_response(**args) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. |
||
@bidi.send_cmd( | ||
'network.continueResponse', | ||
request: args[:request_id], | ||
'body' => args[:body], | ||
'cookies' => args[:cookies], | ||
'credentials' => args[:credentials], | ||
'headers' => args[:headers], | ||
'status' => args[:status] | ||
) | ||
end | ||
|
||
def on(event, &block) | ||
event = EVENTS[event] if event.is_a?(Symbol) | ||
@bidi.add_callback(event, &block) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the method too?