Skip to content

[dotnet] Trim away CDP when publishing AOT apps #15217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RenderMichael merged 2 commits into from
Mar 7, 2025
Merged

[dotnet] Trim away CDP when publishing AOT apps #15217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6fef4
[dotnet] Trim away CDP when publishing AOT apps
RenderMichael Feb 2, 2025
7fc7557
merge trunk
RenderMichael Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dotnet/src/webdriver/WebDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class WebDriver : IWebDriver, ISearchContext, IJavaScriptExecutor, IFinds
/// </summary>
protected static readonly TimeSpan DefaultCommandTimeout = TimeSpan.FromSeconds(60);
private IFileDetector fileDetector = new DefaultFileDetector();
private readonly NetworkManager network;
private NetworkManager network;
private WebElementFactory elementFactory;

private readonly List<string> registeredCommands = new List<string>();
Expand Down Expand Up @@ -73,7 +73,6 @@ protected WebDriver(ICommandExecutor executor, ICapabilities capabilities)
}

this.elementFactory = new WebElementFactory(this);
this.network = new NetworkManager(this);
this.registeredCommands.AddRange(DriverCommand.KnownCommands);

if (this is ISupportsLogs)
Expand Down Expand Up @@ -198,7 +197,7 @@ public virtual IFileDetector FileDetector
set => this.fileDetector = value ?? throw new ArgumentNullException(nameof(value), "FileDetector cannot be null");
}

internal INetwork Network => this.network;
internal INetwork Network => this.network ??= new NetworkManager(this);

/// <summary>
/// Gets or sets the factory object used to create instances of <see cref="WebElement"/>
Expand Down
Loading