[rb][BiDi] Add Browser context activate command#15365
[rb][BiDi] Add Browser context activate command#15365aguspe merged 4 commits intoSeleniumHQ:trunkfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
luke-hill
left a comment
There was a problem hiding this comment.
Good test. I'm guessing in reality this is bringing the window up into focus and loading the about:blank or equivalent page? (i've not seen this bidi command before).
Yes exactly |
Add activate method to browser context
User description
Motivation and Context
This change is added to add full support for the BiDi protocol for our Ruby bindings
For more documentation regarding the activate command:
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added
activatemethod toBrowsingContextfor BiDi protocol support.Implemented integration test for
activatemethod inBrowsingContext.Updated type signature for
activatemethod inBrowsingContextRBS file.Changes walkthrough 📝
browsing_context.rb
Add `activate` method to `BrowsingContext` classrb/lib/selenium/webdriver/bidi/browsing_context.rb
activatemethod toBrowsingContextclass.browsingContext.activatecommand with context ID.browsing_context.rbs
Update type signature for `activate` methodrb/sig/lib/selenium/webdriver/bidi/browsing_context.rbs
activatemethod.activatemethod with optionalcontext_idparameter.browsing_context_spec.rb
Add integration test for `activate` methodrb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
activatemethod.document.hasFocus().