-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Re-add defaults for Chromium kwargs #16372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
The only failure in CI is from Java and unrelated to these changes. |
User description
🔗 Related Issues
#16309
💥 What does this PR do?
This PR fixes a breaking change to the Chromium class
__init__signature inadvertently introduced in #16309. Defaults ofNoneare re-added back as keyword argument defaults forbrowser_nameandvendor_prefix.🔄 Types of changes
PR Type
Bug fix
Description
Re-add
Nonedefaults forbrowser_nameandvendor_prefixparametersFix breaking change in ChromiumDriver
__init__signatureRestore backwards compatibility for Chromium class initialization
Diagram Walkthrough
File Walkthrough
webdriver.py
Restore default parameter values in ChromiumDriver constructorpy/selenium/webdriver/chromium/webdriver.py
browser_nameparameter from requiredstrto optional withNonedefault
vendor_prefixparameter from requiredstrto optional withNonedefaultOptionaltype hints for both parameters