-
-
Couldn't load subscription status.
- Fork 8.6k
[py] Use Chrome instead of Firefox for internal Remote tests #16419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Use Chrome instead of Firefox for internal Remote tests #16419
Conversation
|
I found the weirdest Chrome issue while working on this PR. Any file the test tries to download gets downloaded as an .html (.htm on windows) file instead of the correct file extension. I can't reproduce it when manually launching the same browser or with a simple script... but in the tests, it renames the files (like I have the tests altered to compensate for this, but I have no idea what is going on. |
…HQ#16433) Update pinned browser versions Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
|
@navin772 this is really strange: #16419 (comment) I'm not sure what to do about that, but I think this is good to merge. |
|
I remember seeing this behaviour few months back when implementing something, Does it happen every time? |
yea, the tests do it every time... but I can't figure out how to force it to happen in a regular script using the same options and browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@cgoldberg it was an issue with the webserver that was serving the files, fixed it in #16449, I went wit h |
User description
🔗 Related Issues
Fixes #16417
💥 What does this PR do?
This PR updates the internal Python test suite and CI job to use Chrome instead of Firefox for Remote tests.
This also updates the
driverfixture to cleanup downloaded files between tests if running a Remote WebDriver so we don't leak between tests if we don't close the browser.🔄 Types of changes
PR Type
Tests
Description
Switch Remote WebDriver tests from Firefox to Chrome
Update test fixtures to use
chromium_optionsinstead offirefox_optionsModify CI workflow to run remote tests with Chrome browser
Change default Remote options configuration from Firefox to Chrome
Diagram Walkthrough
File Walkthrough
conftest.py
Update Remote driver default options to Chromepy/conftest.py
remotedriver default options fromFirefoxOptionstoChromeOptions(
goog:chromeOptions)driver
ci-python.yml
Switch CI remote tests to Chrome browser.github/workflows/ci-python.yml
chromeinstead offirefoxfor remotetests
remote_connection_tests.py
Switch Remote test fixtures from Firefox to Chromepy/test/selenium/webdriver/remote/remote_connection_tests.py
firefox_optionsfixture withchromium_optionsin timeouttests
remote_custom_locator_tests.py
Update custom locator test to use Chrome optionspy/test/selenium/webdriver/remote/remote_custom_locator_tests.py
firefox_optionstochromium_options