Skip to content

[java] JSpecify annotations for FileDetector #16482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

[java] JSpecify annotations for FileDetector #16482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6911765
[java] JSpecify annotations for `FileDetector`
mk868 Oct 21, 2025
edf2df8
Merge branch 'trunk' into jspecify-FileDetector
diemol Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion java/src/org/openqa/selenium/remote/FileDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@
package org.openqa.selenium.remote;

import java.io.File;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

/** Used for identifying whether a sequence of chars represents the path to a file. */
@NullMarked
public interface FileDetector {
File getLocalFile(CharSequence... keys);
@Nullable File getLocalFile(CharSequence... keys);
}
5 changes: 4 additions & 1 deletion java/src/org/openqa/selenium/remote/LocalFileDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@

import java.io.File;
import java.util.logging.Logger;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

/** Detects files on the local disk. */
@NullMarked
public class LocalFileDetector implements FileDetector {

private static final Logger LOG = Logger.getLogger(LocalFileDetector.class.getName());

@Override
public File getLocalFile(CharSequence... keys) {
public @Nullable File getLocalFile(CharSequence... keys) {
StringBuilder builder = new StringBuilder();
for (CharSequence chars : keys) {
builder.append(chars);
Expand Down
5 changes: 4 additions & 1 deletion java/src/org/openqa/selenium/remote/UselessFileDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@
package org.openqa.selenium.remote;

import java.io.File;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

/** A file detector that never finds anything. */
@NullMarked
public class UselessFileDetector implements FileDetector {
@Override
public File getLocalFile(CharSequence... keys) {
public @Nullable File getLocalFile(CharSequence... keys) {
return null;
}
}